From 507335ea694edc152200d81ffceb67058ed3d1ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Lemoine?= Date: Wed, 29 Apr 2015 09:10:04 +0200 Subject: [PATCH] Make check-requires.py exit 1 on missing/unused requires --- bin/check-requires.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/bin/check-requires.py b/bin/check-requires.py index 6422985ff2..09503ea291 100644 --- a/bin/check-requires.py +++ b/bin/check-requires.py @@ -181,10 +181,13 @@ def check_requires(closure_lib, *filenames): (filename, uses_linenos[missing_require], missing_require)) missing_count += 1 - if unused_count or missing_count: - logger.error('%d unused goog.requires, %d missing goog.requires' % - (unused_count, missing_count)) + + return (unused_count, missing_count) if __name__ == "__main__": - check_requires(*sys.argv[1:]) + unused_count, missing_count = check_requires(*sys.argv[1:]) + if unused_count > 0 or missing_count > 0: + logger.error('%d unused goog.requires, %d missing goog.requires' % + (unused_count, missing_count)) + sys.exit(1)