From 4f4d12024b39f4e01396c8abc8734a924ac1cc6e Mon Sep 17 00:00:00 2001 From: Bart van den Eijnden Date: Fri, 16 Jan 2015 09:49:58 +0100 Subject: [PATCH] Update CONTRIBUTING style guide with recent guidelines --- CONTRIBUTING.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 74f5d2aa3d..0db2658f73 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -239,6 +239,14 @@ style of the existing OpenLayers 3 code, which includes: * Do not use assignments inside expressions. + * Avoid the use of `goog.array.clone` with arrays (use slice instead). + + * Use `array.length = 0` instead of `goog.array.clear`. + + * Use bracket notation instead of `goog.object.set` and `goog.object.get` (with + two arguments). + + * Use uppercase for `@const` variables. ### Pass the integration tests run automatically by the Travis CI system