From 4e8b10ae1c5e2fb3f768157f1a11b4d5266fa69d Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Fri, 17 Apr 2015 06:35:12 -0600 Subject: [PATCH] Use --ssl-protocol=any in PhantomJS with a page that uses HTTPS The `check-examples` target fails on Travis without this option. We get "SSL handshake failed" when loading resources via HTTPS with whatever the default SSL protocol is. In addition, as a precaution, the --ignore-ssl-errors option is set to true in case anybody adds a resource with an invalid certificate. This option does not get around SSL handshake errors. --- build.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build.py b/build.py index 3c93e3a937..db700dcf72 100755 --- a/build.py +++ b/build.py @@ -708,7 +708,8 @@ def check_examples(t): # Run the examples checks in a pool of threads pool = ThreadPool() for example in all_examples: - pool.add_task(t.run, '%(PHANTOMJS)s', 'bin/check-example.js', example) + pool.add_task(t.run, '%(PHANTOMJS)s', '--ssl-protocol=any', + '--ignore-ssl-errors=true', 'bin/check-example.js', example) errors = pool.wait_completion() if errors: sys.exit(1)