Commit Fix for #654: Layer should not redraw on setVisibility(false). For

some layers, this is a significant performance enhancement. Includes regression
tests.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3041 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Layer.js

@@ -347,7 +347,7 @@ OpenLayers.Layer.prototype = {
         if (visibility != this.visibility) {
             this.visibility = visibility;
             this.display(visibility);
-            if (this.map != null) {
+            if (visibility && this.map != null) {
                 var extent = this.map.getExtent();
                 if (extent != null) {
                     this.moveTo(extent, true);

tests/test_Layer.html

@@ -118,7 +118,7 @@
 
     function test_05_Layer_visibility(t) {
 
-        t.plan(3)
+        t.plan(5)
 
         var layer = new OpenLayers.Layer('Test Layer');
     
@@ -130,6 +130,22 @@
         layer.setVisibility(true);
         t.eq(layer.getVisibility(), true, "setVisibility true works");
        
+        // Need a map in order to have moveTo called.
+        // Tests added for #654.
+        var layer = new OpenLayers.Layer.WMS('Test Layer','http://example.com');
+        var m = new OpenLayers.Map('map');
+        m.addLayer(layer);
+        m.zoomToMaxExtent();
+        
+        layermoved = false; 
+        layer.moveTo = function() { layermoved = true; }
+        
+        layer.setVisibility(false);
+        t.eq(layermoved, false, "Layer didn't move when calling setvis false");
+        
+        layer.setVisibility(true);
+        t.eq(layermoved, true, "Layer moved when calling setvis true.");
+    
     }