From 4923fac359f1bf8dfe2f3107aab93b6dd984c839 Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Fri, 9 Nov 2018 13:45:19 -0700 Subject: [PATCH] Avoid 404 for favicon.ico --- rendering/test.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/rendering/test.js b/rendering/test.js index e9f566e8ac..d536b3d45c 100755 --- a/rendering/test.js +++ b/rendering/test.js @@ -18,8 +18,14 @@ function getHref(entry) { return path.dirname(entry).slice(1) + '/'; } -function notFound(res) { +function notFound(req, res) { return () => { + if (req.url === '/favicon.ico') { + res.writeHead(204); + res.end(); + return; + } + const items = []; for (const key in config.entry) { const href = getHref(config.entry[key]); @@ -43,7 +49,7 @@ function serve(options) { return new Promise((resolve, reject) => { const server = http.createServer((req, res) => { - handler(req, res, notFound(res)); + handler(req, res, notFound(req, res)); }); server.listen(options.port, options.host, err => {