From 9726be64c6ee9e93899bf5ced500336300d418e7 Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Tue, 11 Jun 2013 16:42:39 -0600 Subject: [PATCH 1/2] More useful detail in log messages One line per missing require. Include line number of last use. Include proper syntax for adding requires. --- build.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/build.py b/build.py index 01f46c8939..e20ca1dc54 100755 --- a/build.py +++ b/build.py @@ -481,6 +481,7 @@ def build_check_requires_timestamp(t): provides = set() requires = set() uses = set() + uses_linenos = {} for lineno, line in _strip_comments(open(filename)): m = re.match(r'goog.provide\(\'(.*)\'\);', line) if m: @@ -495,6 +496,7 @@ def build_check_requires_timestamp(t): m = provide_re.search(line) if m: uses.add(m.group()) + uses_linenos[m.group()] = lineno line = line[:m.start()] + line[m.end():] break else: @@ -508,9 +510,10 @@ def build_check_requires_timestamp(t): uses.discard('ol.renderer.%s.Map' % (m.group(1),)) missing_requires = uses - requires - provides if missing_requires: - t.info('%s: missing goog.requires: %s', filename, ', '.join( - sorted(missing_requires))) - missing_count += len(missing_requires) + for missing_require in sorted(missing_requires): + t.info("%s:%d missing goog.requires('%s')" % + (filename, uses_linenos[missing_require], missing_require)) + missing_count += 1 if unused_count or missing_count: t.error('%d unused goog.requires, %d missing goog.requires' % (unused_count, missing_count)) From bb980abe8cda98489ad8b57dbc0e23880d2c5e57 Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Tue, 11 Jun 2013 16:53:55 -0600 Subject: [PATCH 2/2] And the proper syntax --- build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.py b/build.py index e20ca1dc54..57c4ed2b67 100755 --- a/build.py +++ b/build.py @@ -511,7 +511,7 @@ def build_check_requires_timestamp(t): missing_requires = uses - requires - provides if missing_requires: for missing_require in sorted(missing_requires): - t.info("%s:%d missing goog.requires('%s')" % + t.info("%s:%d missing goog.require('%s')" % (filename, uses_linenos[missing_require], missing_require)) missing_count += 1 if unused_count or missing_count: