From 460ea4e809d249ae69f2f0ea6f4574310ed7d9ae Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Mon, 4 Jul 2016 17:07:40 +0200 Subject: [PATCH] Return if a vertex was removed in ol.interaction.Modify#removeVertex_ --- src/ol/interaction/modifyinteraction.js | 5 +++-- test/spec/ol/interaction/modifyinteraction.test.js | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ol/interaction/modifyinteraction.js b/src/ol/interaction/modifyinteraction.js index 412a672ea4..67e9318921 100644 --- a/src/ol/interaction/modifyinteraction.js +++ b/src/ol/interaction/modifyinteraction.js @@ -909,8 +909,9 @@ ol.interaction.Modify.prototype.removePoint = function() { ol.interaction.Modify.prototype.removeVertex_ = function() { var dragSegments = this.dragSegments_; var segmentsByFeature = {}; + var deleted = false; var component, coordinates, dragSegment, geometry, i, index, left; - var newIndex, right, segmentData, uid, deleted; + var newIndex, right, segmentData, uid; for (i = dragSegments.length - 1; i >= 0; --i) { dragSegment = dragSegments[i]; segmentData = dragSegment[0]; @@ -1016,7 +1017,7 @@ ol.interaction.Modify.prototype.removeVertex_ = function() { } } - return true; + return deleted; }; diff --git a/test/spec/ol/interaction/modifyinteraction.test.js b/test/spec/ol/interaction/modifyinteraction.test.js index eb3a7c46a1..4bb3ba4fa3 100644 --- a/test/spec/ol/interaction/modifyinteraction.test.js +++ b/test/spec/ol/interaction/modifyinteraction.test.js @@ -280,8 +280,9 @@ describe('ol.interaction.Modify', function() { simulateEvent('pointerdown', 40, 0, false, 0); simulateEvent('pointerup', 40, 0, false, 0); - modify.removePoint(); + var removed = modify.removePoint(); + expect(removed).to.be(true); expect(first.getGeometry().getRevision()).to.equal(firstRevision + 1); expect(first.getGeometry().getCoordinates()).to.have.length(4); expect(first.getGeometry().getCoordinates()[3][0]).to.equal(40);