From 0cf83c2047059743fac917cd91bf17d1c2dce560 Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Tue, 7 Oct 2014 12:25:01 +0200 Subject: [PATCH 1/2] Add missing 'button' type attribute to html button --- src/ol/control/fullscreencontrol.js | 3 ++- src/ol/control/zoomtoextentcontrol.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ol/control/fullscreencontrol.js b/src/ol/control/fullscreencontrol.js index 83b653e804..f01402efb2 100644 --- a/src/ol/control/fullscreencontrol.js +++ b/src/ol/control/fullscreencontrol.js @@ -46,7 +46,8 @@ ol.control.FullScreen = function(opt_options) { var button = goog.dom.createDom(goog.dom.TagName.BUTTON, { 'class': this.cssClassName_ + '-' + goog.dom.fullscreen.isFullScreen() + - ' ol-has-tooltip' + ' ol-has-tooltip', + 'type': 'button' }); goog.dom.appendChild(button, tip); var buttonHandler = new ol.pointer.PointerEventHandler(button); diff --git a/src/ol/control/zoomtoextentcontrol.js b/src/ol/control/zoomtoextentcontrol.js index 441c939878..7f92fe8ae1 100644 --- a/src/ol/control/zoomtoextentcontrol.js +++ b/src/ol/control/zoomtoextentcontrol.js @@ -39,7 +39,8 @@ ol.control.ZoomToExtent = function(opt_options) { 'role' : 'tooltip' }, tipLabel); var button = goog.dom.createDom(goog.dom.TagName.BUTTON, { - 'class': 'ol-has-tooltip' + 'class': 'ol-has-tooltip', + 'type': 'button' }); goog.dom.appendChild(button, tip); From be6c6ee93cba00311f62773d719e580e9e25e62c Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Tue, 7 Oct 2014 12:25:41 +0200 Subject: [PATCH 2/2] Remove unused ResetRotation name attribute --- src/ol/control/rotatecontrol.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ol/control/rotatecontrol.js b/src/ol/control/rotatecontrol.js index d1284b2c21..0888b36cf9 100644 --- a/src/ol/control/rotatecontrol.js +++ b/src/ol/control/rotatecontrol.js @@ -49,7 +49,6 @@ ol.control.Rotate = function(opt_options) { }, tipLabel); var button = goog.dom.createDom(goog.dom.TagName.BUTTON, { 'class': className + '-reset ol-has-tooltip', - 'name' : 'ResetRotation', 'type' : 'button' }, tip, this.label_);