From 435e5e69164cccedba96c68049d5a2f83097db24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Lemoine?= Date: Thu, 20 Mar 2014 13:19:54 +0100 Subject: [PATCH] Better type checking in ol.Map --- externs/oli.js | 2 +- src/ol/map.js | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/externs/oli.js b/externs/oli.js index 8ad98ea52a..36d3f19097 100644 --- a/externs/oli.js +++ b/externs/oli.js @@ -92,7 +92,7 @@ oli.FrameState.prototype.postRenderFunctions; oli.FrameState.prototype.size; -/** @type {Object} */ +/** @type {Object.} */ oli.FrameState.prototype.skippedFeaturesHash_; diff --git a/src/ol/map.js b/src/ol/map.js index 0b5b72465b..1a72f3bbac 100644 --- a/src/ol/map.js +++ b/src/ol/map.js @@ -372,7 +372,7 @@ ol.Map = function(options) { /** * Hash of features uid to skip drawing. - * @type {Object} + * @type {Object.} * @private */ this.skippedFeaturesHash_ = {}; @@ -939,9 +939,14 @@ ol.Map.prototype.handleSizeChanged_ = function() { */ ol.Map.prototype.handleSkippedFeaturesChange_ = function() { this.skippedFeaturesHash_ = {}; - this.skippedFeatures_.forEach(function(feature) { - this.skippedFeaturesHash_[goog.getUid(feature).toString()] = true; - }, this); + this.skippedFeatures_.forEach( + /** + * @param {ol.Feature} feature Feature. + * @this {ol.Map} + */ + function(feature) { + this.skippedFeaturesHash_[goog.getUid(feature).toString()] = true; + }, this); this.render(); };