Remove opt_this param in forEachTileCoordParentTileRange function

The function is only called by `ol/renderer/canvas/TileLayer` and `opt_this` was always `null`.
This commit is contained in:
Frederic Junod
2019-02-07 11:43:43 +01:00
parent f4fe1babd2
commit 41d231a4c7
2 changed files with 4 additions and 6 deletions
+1 -1
View File
@@ -199,7 +199,7 @@ class CanvasTileLayerRenderer extends CanvasLayerRenderer {
covered = findLoadedTiles(z + 1, childTileRange); covered = findLoadedTiles(z + 1, childTileRange);
} }
if (!covered) { if (!covered) {
tileGrid.forEachTileCoordParentTileRange(tile.tileCoord, findLoadedTiles, null, tmpTileRange, tmpExtent); tileGrid.forEachTileCoordParentTileRange(tile.tileCoord, findLoadedTiles, tmpTileRange, tmpExtent);
} }
} }
+3 -5
View File
@@ -203,14 +203,12 @@ class TileGrid {
/** /**
* @param {import("../tilecoord.js").TileCoord} tileCoord Tile coordinate. * @param {import("../tilecoord.js").TileCoord} tileCoord Tile coordinate.
* @param {function(this: T, number, import("../TileRange.js").default): boolean} callback Callback. * @param {function(number, import("../TileRange.js").default): boolean} callback Callback.
* @param {T=} opt_this The object to use as `this` in `callback`.
* @param {import("../TileRange.js").default=} opt_tileRange Temporary import("../TileRange.js").default object. * @param {import("../TileRange.js").default=} opt_tileRange Temporary import("../TileRange.js").default object.
* @param {import("../extent.js").Extent=} opt_extent Temporary import("../extent.js").Extent object. * @param {import("../extent.js").Extent=} opt_extent Temporary import("../extent.js").Extent object.
* @return {boolean} Callback succeeded. * @return {boolean} Callback succeeded.
* @template T
*/ */
forEachTileCoordParentTileRange(tileCoord, callback, opt_this, opt_tileRange, opt_extent) { forEachTileCoordParentTileRange(tileCoord, callback, opt_tileRange, opt_extent) {
let tileRange, x, y; let tileRange, x, y;
let tileCoordExtent = null; let tileCoordExtent = null;
let z = tileCoord[0] - 1; let z = tileCoord[0] - 1;
@@ -228,7 +226,7 @@ class TileGrid {
} else { } else {
tileRange = this.getTileRangeForExtentAndZ(tileCoordExtent, z, opt_tileRange); tileRange = this.getTileRangeForExtentAndZ(tileCoordExtent, z, opt_tileRange);
} }
if (callback.call(opt_this, z, tileRange)) { if (callback(z, tileRange)) {
return true; return true;
} }
--z; --z;