ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unused 2nd parameter for querySelector call

Browse Source 
I guess the intention was to only serch for nodes contained in the
2nd parameter. That should have been `node.querySelector('...')`
but it doesn't matter in the test environment.
This commit is contained in:
Maximilian Krög
2022-07-31 01:41:03 +02:00
parent c90c4c84c5
commit 417753422e
2 changed files with 10 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/browser/spec/ol/control/mouseposition.test.js
+3 -12
View File
@@ -69,10 +69,7 @@ describe('ol/control/MousePosition', function () {
ctrl.setMap(map); ctrl.setMap(map);
map.renderSync(); map.renderSync();
const element = document.querySelector( const element = document.querySelector('.ol-mouse-position');
'.ol-mouse-position',
map.getTarget()
);
simulateEvent(EventType.POINTEROUT, width + 1, height + 1); simulateEvent(EventType.POINTEROUT, width + 1, height + 1);
expect(element.innerHTML).to.be('some text'); expect(element.innerHTML).to.be('some text');
@@ -89,10 +86,7 @@ describe('ol/control/MousePosition', function () {
ctrl.setMap(map); ctrl.setMap(map);
map.renderSync(); map.renderSync();
const element = document.querySelector( const element = document.querySelector('.ol-mouse-position');
'.ol-mouse-position',
map.getTarget()
);
simulateEvent(EventType.POINTEROUT, width + 1, height + 1); simulateEvent(EventType.POINTEROUT, width + 1, height + 1);
expect(element.innerHTML).to.be(' '); expect(element.innerHTML).to.be(' ');
@@ -112,10 +106,7 @@ describe('ol/control/MousePosition', function () {
ctrl.setMap(map); ctrl.setMap(map);
map.renderSync(); map.renderSync();
const element = document.querySelector( const element = document.querySelector('.ol-mouse-position');
'.ol-mouse-position',
map.getTarget()
);
simulateEvent(EventType.POINTEROUT, width + 1, height + 1); simulateEvent(EventType.POINTEROUT, width + 1, height + 1);
expect(element.innerHTML).to.be(''); expect(element.innerHTML).to.be('');
test/browser/spec/ol/control/scaleline.test.js
+7 -16
View File
@@ -37,10 +37,7 @@ describe('ol.control.ScaleLine', function () {
it('defaults to "ol-scale-line"', function () { it('defaults to "ol-scale-line"', function () {
const ctrl = new ScaleLine(); const ctrl = new ScaleLine();
ctrl.setMap(map); ctrl.setMap(map);
const element = document.querySelector( const element = document.querySelector('.ol-scale-line');
'.ol-scale-line',
map.getTarget()
);
expect(element).to.not.be(null); expect(element).to.not.be(null);
expect(element).to.be.a(HTMLDivElement); expect(element).to.be.a(HTMLDivElement);
}); });
@@ -51,16 +48,10 @@ describe('ol.control.ScaleLine', function () {
ctrl.setMap(map); ctrl.setMap(map);
// check that the default was not chosen // check that the default was not chosen
const element1 = document.querySelector( const element1 = document.querySelector('.ol-scale-line');
'.ol-scale-line',
map.getTarget()
);
expect(element1).to.be(null); expect(element1).to.be(null);
// check if the configured classname was chosen // check if the configured classname was chosen
const element2 = document.querySelector( const element2 = document.querySelector('.humpty-dumpty');
'.humpty-dumpty',
map.getTarget()
);
expect(element2).to.not.be(null); expect(element2).to.not.be(null);
expect(element2).to.be.a(HTMLDivElement); expect(element2).to.be.a(HTMLDivElement);
}); });
@@ -640,7 +631,7 @@ describe('ol.control.ScaleLine', function () {
}) })
); );
map.renderSync(); map.renderSync();
const element = document.querySelector('.ol-scale-text', map.getTarget()); const element = document.querySelector('.ol-scale-text');
expect(element).to.not.be(null); expect(element).to.not.be(null);
expect(element).to.be.a(HTMLDivElement); expect(element).to.be.a(HTMLDivElement);
const text = element.innerText; const text = element.innerText;
@@ -661,7 +652,7 @@ describe('ol.control.ScaleLine', function () {
}) })
); );
map.renderSync(); map.renderSync();
const element = document.querySelector('.ol-scale-text', map.getTarget()); const element = document.querySelector('.ol-scale-text');
expect(element).to.not.be(null); expect(element).to.not.be(null);
expect(element).to.be.a(HTMLDivElement); expect(element).to.be.a(HTMLDivElement);
const text = element.innerText; const text = element.innerText;
@@ -683,7 +674,7 @@ describe('ol.control.ScaleLine', function () {
}) })
); );
map.renderSync(); map.renderSync();
const element = document.querySelector('.ol-scale-text', map.getTarget()); const element = document.querySelector('.ol-scale-text');
expect(element).to.not.be(null); expect(element).to.not.be(null);
expect(element).to.be.a(HTMLDivElement); expect(element).to.be.a(HTMLDivElement);
const text = element.innerText; const text = element.innerText;
@@ -705,7 +696,7 @@ describe('ol.control.ScaleLine', function () {
}) })
); );
map.renderSync(); map.renderSync();
const element = document.querySelector('.ol-scale-text', map.getTarget()); const element = document.querySelector('.ol-scale-text');
expect(element).to.not.be(null); expect(element).to.not.be(null);
expect(element).to.be.a(HTMLDivElement); expect(element).to.be.a(HTMLDivElement);
const text = element.innerText; const text = element.innerText;