decomposed layerswitcher

git-svn-id: http://svn.openlayers.org/trunk/openlayers@84 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Control/LayerSwitcher.js

@@ -49,37 +49,11 @@ OpenLayers.Control.LayerSwitcher.prototype =
         //clear out previous incarnation of LayerSwitcher tabs
         this.div.innerHTML = "";
     
-        var pixel = new OpenLayers.Pixel(this.map.div.clientWidth - 200, 4);
+        var ulCoord = new OpenLayers.Pixel(this.map.div.clientWidth - 200, 4);
-        for(i=0; i < this.map.layers.length; i++) {
+        for( var i = 0; i < this.map.layers.length; i++) {
-        
+            var tab = this.createTab(i, ulCoord);
-            div = OpenLayers.Util.createDiv("LayerControl_layer" + i,
+            this.div.appendChild(tab);
-                                            pixel,
+            ulCoord = ulCoord.add(0, 35);
-                                            new OpenLayers.Size(200, 20));
-            
-            div.innerHTML = this.map.layers[i].name;
-            var visible = this.map.layers[i].getVisibility();
-            if (!visible) {
-                div.style.backgroundColor = 
-                    OpenLayers.Control.LayerSwitcher.NONACTIVE_COLOR;
-                div.style.color = 
-                    OpenLayers.Control.LayerSwitcher.ACTIVE_COLOR;
-            } else {
-                div.style.backgroundColor = 
-                    OpenLayers.Control.LayerSwitcher.ACTIVE_COLOR;
-                div.style.color = 
-                    OpenLayers.Control.LayerSwitcher.NONACTIVE_COLOR;
-            }
-            div.style.padding = "5px";
-            
-            //tag references onto the div for use in event handlers
-            div.layerid = i;
-            div.map = this.map;
-
-            div.ondblclick = this.doubleClick.bindAsEventListener(div);
-            div.onmousedown = this.singleClick.bindAsEventListener(div);
-            this.div.appendChild(div);
-
-            pixel = pixel.add(0, 35);
         }
         return this.div;
     },
@@ -88,19 +62,9 @@ OpenLayers.Control.LayerSwitcher.prototype =
     * @param {event} evt
     */
     singleClick: function(evt) {
-        var visible = this.map.layers[this.layerid].getVisibility();
+        var visible = this.map.layers[this.layerindex].getVisibility();
-        if (visible) {
+        OpenLayers.Control.LayerSwitcher.setTabActivation(this, !visible);
-            this.style.backgroundColor = 
+        this.map.layers[this.layerindex].setVisibility(!visible);
-                OpenLayers.Control.LayerSwitcher.NONACTIVE_COLOR;
-            this.style.color = 
-                OpenLayers.Control.LayerSwitcher.ACTIVE_COLOR;
-        } else {
-            this.style.backgroundColor = 
-                OpenLayers.Control.LayerSwitcher.ACTIVE_COLOR;
-            this.style.color = 
-                OpenLayers.Control.LayerSwitcher.NONACTIVE_COLOR;
-        }
-        this.map.layers[this.layerid].setVisibility(!visible);
         Event.stop(evt);
     },
     
@@ -111,6 +75,59 @@ OpenLayers.Control.LayerSwitcher.prototype =
         Event.stop(evt);
     },
 
+    /** 
+    * @private
+    * 
+    * @param {int} index
+    * @param {OpenLayers.Pixel} ulCoord
+    * 
+    * @returns New tab (div) with layer information inside
+    * @type DOMElement
+    */            
+    createTab: function(index, ulCoord) {
+    
+        var layer = this.map.layers[index];
+    
+        var divID = "LayerSwitcher_" + layer.name + "_Tab";
+        var div = OpenLayers.Util.createDiv(divID, 
+                                            ulCoord,
+                                            new OpenLayers.Size(200, 20));
+        
+        div.innerHTML = layer.name;
+        div.style.padding = "5px";
+        
+        //add references onto the div for use in event handlers
+        div.layerindex = index;
+        div.map = this.map;
+
+        div.ondblclick = this.doubleClick.bindAsEventListener(div);
+        div.onmousedown = this.singleClick.bindAsEventListener(div);
+        
+        OpenLayers.Control.LayerSwitcher.setTabActivation(div, 
+                                                        layer.getVisibility());
+                                                        
+        return div;
+    },
+
+
     /** @type String */
     CLASS_NAME: "OpenLayers.Control.LayerSwitcher"
 });
+
+
+/**
+* @private
+*
+* @param {bool}
+*/
+OpenLayers.Control.LayerSwitcher.setTabActivation = function(div, activate) {
+
+    div.style.backgroundColor = (activate) ?
+        OpenLayers.Control.LayerSwitcher.ACTIVE_COLOR
+        : OpenLayers.Control.LayerSwitcher.NONACTIVE_COLOR;
+
+    div.style.color = (activate) ?
+        OpenLayers.Control.LayerSwitcher.NONACTIVE_COLOR
+        : OpenLayers.Control.LayerSwitcher.ACTIVE_COLOR;
+};
+