Rename tileUsage to usedTiles

This commit is contained in:
Tom Payne
2013-01-18 16:46:32 +01:00
parent 1c524caae6
commit 3ec2014ad1
7 changed files with 22 additions and 23 deletions

View File

@@ -69,7 +69,7 @@ ol.control.Attribution.prototype.handleMapPostrender = function(mapEvent) {
if (goog.isNull(frameState)) { if (goog.isNull(frameState)) {
this.updateElement_(null); this.updateElement_(null);
} else { } else {
this.updateElement_(frameState.tileUsage); this.updateElement_(frameState.usedTiles);
} }
}; };
@@ -94,12 +94,12 @@ ol.control.Attribution.prototype.setMap = function(map) {
/** /**
* @private * @private
* @param {?Object.<string, Object.<string, ol.TileRange>>} tileUsage Tile * @param {?Object.<string, Object.<string, ol.TileRange>>} usedTiles Used
* usage. * tiles.
*/ */
ol.control.Attribution.prototype.updateElement_ = function(tileUsage) { ol.control.Attribution.prototype.updateElement_ = function(usedTiles) {
if (goog.isNull(tileUsage)) { if (goog.isNull(usedTiles)) {
if (this.renderedVisible_) { if (this.renderedVisible_) {
goog.style.showElement(this.element, false); goog.style.showElement(this.element, false);
this.renderedVisible_ = false; this.renderedVisible_ = false;
@@ -136,14 +136,14 @@ ol.control.Attribution.prototype.updateElement_ = function(tileUsage) {
var attributions = {}; var attributions = {};
var i, tileRanges, tileSource, tileSourceAttribution, var i, tileRanges, tileSource, tileSourceAttribution,
tileSourceAttributionKey, tileSourceAttributions, tileSourceKey, z; tileSourceAttributionKey, tileSourceAttributions, tileSourceKey, z;
for (tileSourceKey in tileUsage) { for (tileSourceKey in usedTiles) {
goog.asserts.assert(tileSourceKey in tileSources); goog.asserts.assert(tileSourceKey in tileSources);
tileSource = tileSources[tileSourceKey]; tileSource = tileSources[tileSourceKey];
tileSourceAttributions = tileSource.getAttributions(); tileSourceAttributions = tileSource.getAttributions();
if (goog.isNull(tileSourceAttributions)) { if (goog.isNull(tileSourceAttributions)) {
continue; continue;
} }
tileRanges = tileUsage[tileSourceKey]; tileRanges = usedTiles[tileSourceKey];
for (i = 0; i < tileSourceAttributions.length; ++i) { for (i = 0; i < tileSourceAttributions.length; ++i) {
tileSourceAttribution = tileSourceAttributions[i]; tileSourceAttribution = tileSourceAttributions[i];
tileSourceAttributionKey = goog.getUid(tileSourceAttribution).toString(); tileSourceAttributionKey = goog.getUid(tileSourceAttribution).toString();

View File

@@ -1,6 +1,5 @@
// FIXME add view3DState // FIXME add view3DState
// FIXME rename tileUsage to usedTiles // FIXME factor out common code between usedTiles and wantedTiles
// FIXME factor out common code between tileUsage and wantedTiles
goog.provide('ol.FrameState'); goog.provide('ol.FrameState');
goog.provide('ol.PostRenderFunction'); goog.provide('ol.PostRenderFunction');
@@ -28,8 +27,8 @@ goog.require('ol.layer.LayerState');
* postRenderFunctions: Array.<ol.PostRenderFunction>, * postRenderFunctions: Array.<ol.PostRenderFunction>,
* size: ol.Size, * size: ol.Size,
* tileQueue: ol.TileQueue, * tileQueue: ol.TileQueue,
* tileUsage: Object.<string, Object.<string, ol.TileRange>>,
* time: number, * time: number,
* usedTiles: Object.<string, Object.<string, ol.TileRange>>,
* view2DState: ol.View2DState, * view2DState: ol.View2DState,
* viewHints: Array.<number>, * viewHints: Array.<number>,
* wantedTiles: Object.<string, Object.<string, ol.TileRange>>}} * wantedTiles: Object.<string, Object.<string, ol.TileRange>>}}

View File

@@ -632,8 +632,8 @@ ol.Map.prototype.renderFrame_ = function(time) {
postRenderFunctions: [], postRenderFunctions: [],
size: size, size: size,
tileQueue: this.tileQueue_, tileQueue: this.tileQueue_,
tileUsage: {},
time: time, time: time,
usedTiles: {},
view2DState: view2DState, view2DState: view2DState,
viewHints: viewHints, viewHints: viewHints,
wantedTiles: {} wantedTiles: {}

View File

@@ -216,7 +216,7 @@ ol.renderer.canvas.TileLayer.prototype.renderFrame =
frameState.animate = true; frameState.animate = true;
} }
this.updateTileUsage(frameState.tileUsage, tileSource, z, tileRange); this.updateUsedTiles(frameState.usedTiles, tileSource, z, tileRange);
this.updateWantedTiles(frameState.wantedTiles, tileSource, z, tileRange); this.updateWantedTiles(frameState.wantedTiles, tileSource, z, tileRange);
var transform = this.transform_; var transform = this.transform_;

View File

@@ -237,7 +237,7 @@ ol.renderer.dom.TileLayer.prototype.renderFrame =
frameState.animate = true; frameState.animate = true;
} }
this.updateTileUsage(frameState.tileUsage, tileSource, z, tileRange); this.updateUsedTiles(frameState.usedTiles, tileSource, z, tileRange);
this.updateWantedTiles(frameState.wantedTiles, tileSource, z, tileRange); this.updateWantedTiles(frameState.wantedTiles, tileSource, z, tileRange);
}; };

View File

@@ -130,25 +130,25 @@ ol.renderer.Layer.prototype.handleLayerVisibleChange = goog.nullFunction;
/** /**
* @protected * @protected
* @param {Object.<string, Object.<string, ol.TileRange>>} tileUsage Tile usage. * @param {Object.<string, Object.<string, ol.TileRange>>} usedTiles Used tiles.
* @param {ol.source.Source} source Source. * @param {ol.source.Source} source Source.
* @param {number} z Z. * @param {number} z Z.
* @param {ol.TileRange} tileRange Tile range. * @param {ol.TileRange} tileRange Tile range.
*/ */
ol.renderer.Layer.prototype.updateTileUsage = ol.renderer.Layer.prototype.updateUsedTiles =
function(tileUsage, source, z, tileRange) { function(usedTiles, source, z, tileRange) {
// FIXME should we use tilesToDrawByZ instead? // FIXME should we use tilesToDrawByZ instead?
var sourceKey = goog.getUid(source).toString(); var sourceKey = goog.getUid(source).toString();
var zKey = z.toString(); var zKey = z.toString();
if (sourceKey in tileUsage) { if (sourceKey in usedTiles) {
if (zKey in tileUsage[sourceKey]) { if (zKey in usedTiles[sourceKey]) {
tileUsage[sourceKey][zKey].extend(tileRange); usedTiles[sourceKey][zKey].extend(tileRange);
} else { } else {
tileUsage[sourceKey][zKey] = tileRange; usedTiles[sourceKey][zKey] = tileRange;
} }
} else { } else {
tileUsage[sourceKey] = {}; usedTiles[sourceKey] = {};
tileUsage[sourceKey][zKey] = tileRange; usedTiles[sourceKey][zKey] = tileRange;
} }
}; };

View File

@@ -460,7 +460,7 @@ ol.renderer.webgl.TileLayer.prototype.renderFrame =
} }
this.updateTileUsage(frameState.tileUsage, tileSource, z, tileRange); this.updateUsedTiles(frameState.usedTiles, tileSource, z, tileRange);
this.updateWantedTiles(frameState.wantedTiles, tileSource, z, tileRange); this.updateWantedTiles(frameState.wantedTiles, tileSource, z, tileRange);
goog.vec.Mat4.makeIdentity(this.matrix_); goog.vec.Mat4.makeIdentity(this.matrix_);