From 974684ed2b156a66348432c7c60f2f98702e71dd Mon Sep 17 00:00:00 2001 From: ahocevar Date: Mon, 18 Feb 2019 23:49:52 +0100 Subject: [PATCH 1/2] Use Puppeteer for tests --- test/karma.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/karma.config.js b/test/karma.config.js index 379a91b911..f7dd53a6d2 100644 --- a/test/karma.config.js +++ b/test/karma.config.js @@ -74,6 +74,7 @@ module.exports = function(karma) { } }); + process.env.CHROME_BIN = require('puppeteer').executablePath(); if (process.env.CIRCLECI) { karma.set({ browsers: ['Chrome'], From be17bfe85af859a506862f66cf641873299d0029 Mon Sep 17 00:00:00 2001 From: ahocevar Date: Mon, 18 Feb 2019 23:50:31 +0100 Subject: [PATCH 2/2] Avoid render test issues by not running Puppeteer in headless mode --- rendering/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rendering/test.js b/rendering/test.js index d6d0e93b61..a6653316b4 100755 --- a/rendering/test.js +++ b/rendering/test.js @@ -351,7 +351,7 @@ if (require.main === module) { option('headless', { describe: 'Launch Puppeteer in headless mode', type: 'boolean', - default: process.env.CI ? false : true + default: false }). option('puppeteer-args', { describe: 'Additional args for Puppeteer',