improve map's getLayer() function, includes improved test. cheers to pensyakito for bringing this up and to cr5 for the review (Closes #861)

git-svn-id: http://svn.openlayers.org/trunk/openlayers@5221 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Map.js

@@ -475,6 +475,7 @@ OpenLayers.Map = OpenLayers.Class({
             var layer = this.layers[i];
             if (layer.id == id) {
                 foundLayer = layer;
+                break;
             }
         }
         return foundLayer;

tests/test_Map.html

@@ -242,21 +242,23 @@
     }
 
     function test_10_Map_getLayer(t) {
-        t.plan( 2 );    
+        var numLayers = 3;
+        t.plan( numLayers + 1 );    
 
-        map = new OpenLayers.Map('map');
+        var m = {
-        layer = new OpenLayers.Layer.WMS('Test Layer', 
+            layers: []
-                    "http://octo.metacarta.com/cgi-bin/mapserv", 
+        };
-                    {map: '/mapdata/vmap_wms.map', layers: 'basic', format: 'image/jpeg'}, 
+        
-                    {maxExtent: new OpenLayers.Bounds(33861, 717605, 330846, 1019656), maxResolution: 296985/1024, projection:"EPSG:2805" } );
+        for(var i = 0; i < numLayers; i++) {
+            m.layers.push( { 'id': i } );
+        }
 
-        map.addLayer(layer);
+        for(var i = 0; i < numLayers; i++) {
-        var gotLayer = map.getLayer(layer.id);
+            var layer = OpenLayers.Map.prototype.getLayer.apply(m, [i]);
-
+            t.ok( layer == m.layers[i], "getLayer correctly returns layer " + i);
-        t.ok( layer == gotLayer, "getLayer correctly returns layer" );
+        }
-
-        gotLayer = map.getLayer("chicken");
 
+        var gotLayer = OpenLayers.Map.prototype.getLayer.apply(m, ["chicken"]);
         t.ok( gotLayer == null, "getLayer correctly returns null when layer not found");
     }