From 3959e9b76f292cebb6493b2a3496f7dfbe800ca6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandre=20Dub=C3=A9?= Date: Mon, 15 Aug 2016 10:49:36 -0400 Subject: [PATCH] Fix #5730 - Ignore null/undef. values in uri.appendParams --- src/ol/uri.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/ol/uri.js b/src/ol/uri.js index 8c45e6bbf8..387d4f5e96 100644 --- a/src/ol/uri.js +++ b/src/ol/uri.js @@ -10,9 +10,14 @@ goog.provide('ol.uri'); * @return {string} The new URI. */ ol.uri.appendParams = function(uri, params) { - var qs = Object.keys(params).map(function(k) { - return k + '=' + encodeURIComponent(params[k]); - }).join('&'); + var keyParams = []; + // Skip any null or undefined parameter values + Object.keys(params).forEach(function(k) { + if (params[k] !== null && params[k] !== undefined) { + keyParams.push(k + '=' + encodeURIComponent(params[k])); + } + }); + var qs = keyParams.join('&'); // remove any trailing ? or & uri = uri.replace(/[?&]$/, ''); // append ? or & depending on whether uri has existing parameters