From 483c4426215ac109f6c8308bf4b1171092c8032a Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Mon, 17 Dec 2018 09:55:28 +0100 Subject: [PATCH 1/2] Remove suppress jsdoc tags --- src/ol/format/MVT.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/ol/format/MVT.js b/src/ol/format/MVT.js index 8a47aad0b7..0776c26064 100644 --- a/src/ol/format/MVT.js +++ b/src/ol/format/MVT.js @@ -94,7 +94,6 @@ class MVT extends FeatureFormat { /** * Read the raw geometry from the pbf offset stored in a raw feature's geometry * property. - * @suppress {missingProperties} * @param {Object} pbf PBF. * @param {Object} feature Raw feature. * @param {Array} flatCoordinates Array to store flat coordinates in. @@ -367,7 +366,6 @@ function featurePBFReader(tag, feature, pbf) { /** * Read a raw feature from the pbf offset stored at index `i` in the raw layer. - * @suppress {missingProperties} * @param {Object} pbf PBF. * @param {Object} layer Raw layer. * @param {number} i Index of the feature in the raw layer's `features` array. @@ -388,7 +386,6 @@ function readRawFeature(pbf, layer, i) { /** - * @suppress {missingProperties} * @param {number} type The raw feature's geometry type * @param {number} numEnds Number of ends of the flat coordinates of the * geometry. From 3b57f6693cefcdfc8a30de56b9b039948d7c895b Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Mon, 17 Dec 2018 10:30:48 +0100 Subject: [PATCH 2/2] Use 'PBF' type instead of 'Object' --- src/ol/format/MVT.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ol/format/MVT.js b/src/ol/format/MVT.js index 0776c26064..62088e9b39 100644 --- a/src/ol/format/MVT.js +++ b/src/ol/format/MVT.js @@ -94,7 +94,7 @@ class MVT extends FeatureFormat { /** * Read the raw geometry from the pbf offset stored in a raw feature's geometry * property. - * @param {Object} pbf PBF. + * @param {PBF} pbf PBF. * @param {Object} feature Raw feature. * @param {Array} flatCoordinates Array to store flat coordinates in. * @param {Array} ends Array to store ends in. @@ -157,7 +157,7 @@ class MVT extends FeatureFormat { /** * @private - * @param {Object} pbf PBF + * @param {PBF} pbf PBF * @param {Object} rawFeature Raw Mapbox feature. * @param {import("./Feature.js").ReadOptions=} opt_options Read options. * @return {import("../Feature.js").FeatureLike} Feature. @@ -288,7 +288,7 @@ class MVT extends FeatureFormat { * Reader callback for parsing layers. * @param {number} tag The tag. * @param {Object} layers The layers object. - * @param {Object} pbf The PBF. + * @param {PBF} pbf The PBF. */ function layersPBFReader(tag, layers, pbf) { if (tag === 3) { @@ -310,7 +310,7 @@ function layersPBFReader(tag, layers, pbf) { * Reader callback for parsing layer. * @param {number} tag The tag. * @param {Object} layer The layer object. - * @param {Object} pbf The PBF. + * @param {PBF} pbf The PBF. */ function layerPBFReader(tag, layer, pbf) { if (tag === 15) { @@ -344,7 +344,7 @@ function layerPBFReader(tag, layer, pbf) { * Reader callback for parsing feature. * @param {number} tag The tag. * @param {Object} feature The feature object. - * @param {Object} pbf The PBF. + * @param {PBF} pbf The PBF. */ function featurePBFReader(tag, feature, pbf) { if (tag == 1) { @@ -366,7 +366,7 @@ function featurePBFReader(tag, feature, pbf) { /** * Read a raw feature from the pbf offset stored at index `i` in the raw layer. - * @param {Object} pbf PBF. + * @param {PBF} pbf PBF. * @param {Object} layer Raw layer. * @param {number} i Index of the feature in the raw layer's `features` array. * @return {Object} Raw feature.