From 332fd250b461c3afd240279b8eb8ac03582b583b Mon Sep 17 00:00:00 2001 From: Tom Payne Date: Sat, 20 Apr 2013 11:27:44 +0200 Subject: [PATCH] Cache array length in ol.Collection --- src/ol/collection.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/ol/collection.js b/src/ol/collection.js index 08d3340188..147e03abac 100644 --- a/src/ol/collection.js +++ b/src/ol/collection.js @@ -87,8 +87,8 @@ ol.Collection.prototype.clear = function() { * @param {Array} arr Array. */ ol.Collection.prototype.extend = function(arr) { - var i; - for (i = 0; i < arr.length; ++i) { + var i, ii; + for (i = 0, ii = arr.length; i < ii; ++i) { this.push(arr[i]); } }; @@ -165,9 +165,10 @@ ol.Collection.prototype.push = function(elem) { * @return {*} The removed element or undefined if elem was not found. */ ol.Collection.prototype.remove = function(elem) { - var i; - for (i = 0; i < this.array_.length; ++i) { - if (this.array_[i] === elem) { + var arr = this.array_; + var i, ii; + for (i = 0, ii = arr.length; i < ii; ++i) { + if (arr[i] === elem) { return this.removeAt(i); } }