From 32ca128b188ac53eceb3365cb6d8a051958f97d7 Mon Sep 17 00:00:00 2001
From: crschmidt <crschmidt@crschmidt.net>
Date: Wed, 28 Jan 2009 02:07:09 +0000
Subject: [PATCH] Simple fix to KML style parsing (from Edgemaster). This
 change makes getStyle return clones. Since the results of getStyle are
 extended later in the code by the inlineStyle, this fixes a case where
 kml.styleUrl symbolizers can be changed by <Style> blocks attached to
 features which share a style. r=me. (Closes #1578)

git-svn-id: http://svn.openlayers.org/trunk/openlayers@8776 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
---
 lib/OpenLayers/Format/KML.js | 2 +-
 tests/Format/KML.html        | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/lib/OpenLayers/Format/KML.js b/lib/OpenLayers/Format/KML.js
index 68a41ce0ac..73ed1eb2dd 100644
--- a/lib/OpenLayers/Format/KML.js
+++ b/lib/OpenLayers/Format/KML.js
@@ -663,7 +663,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
         }
 
         // return requested style
-        var style = this.styles[styleUrl];
+        var style = OpenLayers.Util.extend({}, this.styles[styleUrl]);
         return style;
     },
     
diff --git a/tests/Format/KML.html b/tests/Format/KML.html
index c16bbb7c78..0b123d4326 100644
--- a/tests/Format/KML.html
+++ b/tests/Format/KML.html
@@ -143,6 +143,15 @@
         var features = f.read(test_style_fill);    
         t.eq(features[0].style.fillColor, "none", "KML Feature has none fill");        
     } 
+    function test_Format_KML_getStyle(t) {
+        t.plan(1);
+        var style = {t: true};
+        var f = new OpenLayers.Format.KML();
+        f.styles = {test: style};
+        var gotStyle = f.getStyle('test');
+        gotStyle.t = false;
+        t.ok(style.t, "getStyle returns copy of style rather than reference");
+    }
 
     </script> 
 </head>