From 329edc4ec64d7995af0962a4d384356c8d874d57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Lemoine?= Date: Tue, 24 Feb 2015 15:14:10 +0100 Subject: [PATCH] Make ol.Overlay autoPan default to false --- examples/measure.js | 6 ++---- examples/popup.js | 1 + examples/tileutfgrid.js | 3 +-- externs/olx.js | 2 +- src/ol/overlay.js | 2 +- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/measure.js b/examples/measure.js index ec62e62f52..c437e778c2 100644 --- a/examples/measure.js +++ b/examples/measure.js @@ -204,8 +204,7 @@ function createHelpTooltip() { helpTooltip = new ol.Overlay({ element: helpTooltipElement, offset: [15, 0], - positioning: 'center-left', - autoPan: false + positioning: 'center-left' }); map.addOverlay(helpTooltip); } @@ -223,8 +222,7 @@ function createMeasureTooltip() { measureTooltip = new ol.Overlay({ element: measureTooltipElement, offset: [0, -15], - positioning: 'bottom-center', - autoPan: false + positioning: 'bottom-center' }); map.addOverlay(measureTooltip); } diff --git a/examples/popup.js b/examples/popup.js index 2ed85da5f5..be01b0c29a 100644 --- a/examples/popup.js +++ b/examples/popup.js @@ -31,6 +31,7 @@ closer.onclick = function() { */ var overlay = new ol.Overlay(/** @type {olx.OverlayOptions} */ ({ element: container, + autoPan: true, autoPanAnimation: { duration: 250 } diff --git a/examples/tileutfgrid.js b/examples/tileutfgrid.js index cb97ce4e2d..89a26759b3 100644 --- a/examples/tileutfgrid.js +++ b/examples/tileutfgrid.js @@ -36,8 +36,7 @@ var nameElement = document.getElementById('country-name'); var infoOverlay = new ol.Overlay({ element: infoElement, offset: [15, 15], - stopEvent: false, - autoPan: false + stopEvent: false }); map.addOverlay(infoOverlay); diff --git a/externs/olx.js b/externs/olx.js index 6705e3a3bf..291fc907e4 100644 --- a/externs/olx.js +++ b/externs/olx.js @@ -382,7 +382,7 @@ olx.OverlayOptions.prototype.insertFirst; /** * If set to `true` the map is panned when calling `setPosition`, so that the * overlay is entirely visible in the current viewport. - * The default is `true`. + * The default is `false`. * @type {boolean|undefined} * @api */ diff --git a/src/ol/overlay.js b/src/ol/overlay.js index 8b18d4f845..5d3a30fe18 100644 --- a/src/ol/overlay.js +++ b/src/ol/overlay.js @@ -97,7 +97,7 @@ ol.Overlay = function(options) { * @private * @type {boolean} */ - this.autoPan_ = goog.isDef(options.autoPan) ? options.autoPan : true; + this.autoPan_ = goog.isDef(options.autoPan) ? options.autoPan : false; /** * @private