From 04deaa30320d7415868dee45329f518e39e09961 Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Wed, 8 Feb 2017 13:36:48 +0100 Subject: [PATCH 1/2] Remove console.assert in ol.structs.PriorityQueue tests --- test/spec/ol/structs/priorityqueue.test.js | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/test/spec/ol/structs/priorityqueue.test.js b/test/spec/ol/structs/priorityqueue.test.js index 21c21ecdcd..50340d2483 100644 --- a/test/spec/ol/structs/priorityqueue.test.js +++ b/test/spec/ol/structs/priorityqueue.test.js @@ -11,19 +11,9 @@ describe('ol.structs.PriorityQueue', function() { describe('when empty', function() { - var pq, origAssert; + var pq; beforeEach(function() { - origAssert = console.assert; - console.assert = function(assertion, message) { - if (!assertion) { - throw new Error(message); - } - }; - pq = new ol.structs.PriorityQueue( - identity, identity); - }); - afterEach(function() { - console.assert = origAssert; + pq = new ol.structs.PriorityQueue(identity, identity); }); it('is empty', function() { From e9fb061704f703956a4a9a7a6dcd46e5205b7e66 Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Wed, 8 Feb 2017 13:45:27 +0100 Subject: [PATCH 2/2] Remove no-console eslint rule --- package.json | 9 --------- 1 file changed, 9 deletions(-) diff --git a/package.json b/package.json index ea818b24df..d622507851 100644 --- a/package.json +++ b/package.json @@ -89,15 +89,6 @@ "openlayers-internal" ], "rules": { - "no-console": [ - 2, - { - "allow": [ - "assert", - "warn" - ] - } - ], "no-constant-condition": 0, "openlayers-internal/enum": 2, "openlayers-internal/no-duplicate-requires": 2,