From 2dd3fbf307e82fd157b759e3248a2e8fb94025b1 Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Fri, 17 Apr 2015 16:09:43 -0600 Subject: [PATCH] Renaming and docs for clarity --- tasks/build-examples.js | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tasks/build-examples.js b/tasks/build-examples.js index 9ab31e2d0a..10c0ee1ddd 100644 --- a/tasks/build-examples.js +++ b/tasks/build-examples.js @@ -8,7 +8,7 @@ var pkg = require('../package.json'); var markupRegEx = /([^\/^\.]*)\.html$/; var cleanupJSRegEx = /.*(goog\.require(.*);|.*renderer: common\..*,?)[\n]*/g; -var googRequiresRegEx = /.*goog\.require\('(ol\.\S*)'\);/g; +var requiresRegEx = /.*goog\.require\('(ol\.\S*)'\);/g; var isCssRegEx = /\.css$/; var isJsRegEx = /\.js$/; @@ -17,20 +17,20 @@ var destDir = path.join(__dirname, '..', 'build', 'examples'); var templatesDir = path.join(__dirname, '..', 'config', 'examples'); /** - * Returns an array of classes that are explicitly required inside the source - * by calling 'goog.require(…)' + * Returns an array of names that are explicitly required inside the source + * by calling `goog.require('ol.…')`. Only returns `ol.` prefixed names. * * @param {string} src The JavaScript sourcecode to search for goog.require. - * @returns {Array.} An array of ol-classes that the source requires. + * @returns {Array.} An array of `ol.*` names. */ -function getGoogRequires(src) { - var googRequires = []; - var match = googRequiresRegEx.exec(src); +function getRequires(src) { + var requires = []; + var match = requiresRegEx.exec(src); while (match) { - googRequires.push(match[1]); - match = googRequiresRegEx.exec(src); + requires.push(match[1]); + match = requiresRegEx.exec(src); } - return googRequires; + return requires; } /** @@ -38,12 +38,12 @@ function getGoogRequires(src) { * HTML-snippet with an unordered list to the API-docs for the particular * classes. * - * @param {Array.} googRequires An array of ol-classes that the source + * @param {Array.} requires An array of `ol.` names that the source * requires. * @returns {string} The HTML-snippet with the list of links to API-docs. */ -function getLinkToApiHtml(googRequires) { - var lis = googRequires.map(function(symb) { +function getLinkToApiHtml(requires) { + var lis = requires.map(function(symb) { var href = '../apidoc/' + symb + '.html'; return '
  • ' + symb + '
  • '; @@ -83,7 +83,7 @@ function augmentExamples(files, metalsmith, done) { throw new Error('No .js file found for ' + filename); } var jsSource = files[jsFilename].contents.toString(); - var requires = getGoogRequires(jsSource); + var requires = getRequires(jsSource); file.requires = requires; file.js = { tag: '',