From 2b84e0f2457fbc8c58b3bce642169d6803b2355b Mon Sep 17 00:00:00 2001 From: Marc Jansen Date: Tue, 29 Sep 2015 15:24:25 +0200 Subject: [PATCH] Remove goog.isNull in overlay class --- src/ol/overlay.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ol/overlay.js b/src/ol/overlay.js index 1d85f00566..fdb57047b3 100644 --- a/src/ol/overlay.js +++ b/src/ol/overlay.js @@ -254,7 +254,7 @@ ol.Overlay.prototype.handleElementChanged = function() { * @protected */ ol.Overlay.prototype.handleMapChanged = function() { - if (!goog.isNull(this.mapPostrenderListenerKey_)) { + if (this.mapPostrenderListenerKey_) { goog.dom.removeNode(this.element_); goog.events.unlistenByKey(this.mapPostrenderListenerKey_); this.mapPostrenderListenerKey_ = null; @@ -366,7 +366,7 @@ ol.Overlay.prototype.panIntoView_ = function() { goog.asserts.assert(this.autoPan, 'this.autoPan should be true'); var map = this.getMap(); - if (map === undefined || goog.isNull(map.getTargetElement())) { + if (map === undefined || !map.getTargetElement()) { return; } @@ -409,7 +409,7 @@ ol.Overlay.prototype.panIntoView_ = function() { centerPx[1] + delta[1] ]; - if (!goog.isNull(this.autoPanAnimation_)) { + if (this.autoPanAnimation_) { this.autoPanAnimation_.source = center; map.beforeRender(ol.animation.pan(this.autoPanAnimation_)); } @@ -489,7 +489,7 @@ ol.Overlay.prototype.updatePixelPosition = function() { * @protected */ ol.Overlay.prototype.updateRenderedPosition = function(pixel, mapSize) { - goog.asserts.assert(!goog.isNull(pixel), 'pixel should not be null'); + goog.asserts.assert(pixel, 'pixel should not be null'); goog.asserts.assert(mapSize !== undefined, 'mapSize should be defined'); var style = this.element_.style; var offset = this.getOffset();