ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove goog.dom.ViewportSizeMonitor

Browse Source
This commit is contained in:
Andreas Hocevar
2016-01-27 16:28:18 +01:00
parent 7e27ba1d42
commit 2b451e7893
5 changed files with 14 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/index.html
View File

@@ -32,22 +32,6 @@
goog.json.USE_NATIVE_JSON = true;
/**
* The goog.dom.ViewportSizeMonitor (used in map.js) creates a global leak
* by setting goog.UID_PROPERTY_ on the monitored window. In order to test
* that we don't have other global leaks, we preemptively set the property
* so Mocha can compare the global before and after our tests.
*
* In addition, calling ol.events.listen on the global object (as done
* in deviceorientation.js) creates a second leak by setting
* ol.events.listenER_MAP_PROP_ on the global object.
*
* We preemptively set both of these properties so Mocha can compare the
* global before and after tests. The call to ol.events.listen also
* calls goog.getUid.
*/
ol.events.listen(this, 'test', function() {});
var runner = mocha.run();
if (window.console && console.log) {
// write stacks to the console for failed tests

13
test/spec/ol/map.test.js
View File

@@ -211,17 +211,13 @@ describe('ol.Map', function() {
map = new ol.Map({
target: document.createElement('div')
});
var viewportResizeListeners = map.viewportSizeMonitor_.getListeners(
ol.events.EventType.RESIZE, false);
expect(viewportResizeListeners).to.have.length(1);
expect(map.handleResize_).to.be.ok();
});
describe('call setTarget with null', function() {
it('unregisters the viewport resize listener', function() {
map.setTarget(null);
var viewportResizeListeners = map.viewportSizeMonitor_.getListeners(
ol.events.EventType.RESIZE, false);
expect(viewportResizeListeners).to.have.length(0);
expect(map.handleResize_).to.be(undefined);
});
});
@@ -229,9 +225,7 @@ describe('ol.Map', function() {
it('registers a viewport resize listener', function() {
map.setTarget(null);
map.setTarget(document.createElement('div'));
var viewportResizeListeners = map.viewportSizeMonitor_.getListeners(
ol.events.EventType.RESIZE, false);
expect(viewportResizeListeners).to.have.length(1);
expect(map.handleResize_).to.be.ok();
});
});
@@ -401,7 +395,6 @@ describe('ol.Map', function() {
goog.require('goog.dispose');
goog.require('goog.dom');
goog.require('ol.events.EventType');
goog.require('ol.Map');
goog.require('ol.MapEvent');
goog.require('ol.Overlay');