From 2b3e0bf69908963a295edf884bc7bce6369b14a4 Mon Sep 17 00:00:00 2001
From: Frederic Junod <frederic.junod@camptocamp.com>
Date: Tue, 19 Aug 2014 09:55:18 +0200
Subject: [PATCH] Don't create unnecessary closure in constructor

---
 src/ol/source/staticvectorsource.js | 30 ++++++++++++-----------------
 1 file changed, 12 insertions(+), 18 deletions(-)

diff --git a/src/ol/source/staticvectorsource.js b/src/ol/source/staticvectorsource.js
index 24c2aa7393..cd68db8075 100644
--- a/src/ol/source/staticvectorsource.js
+++ b/src/ol/source/staticvectorsource.js
@@ -50,32 +50,26 @@ ol.source.StaticVector = function(options) {
   if (goog.isDef(options.url) || goog.isDef(options.urls)) {
     this.setState(ol.source.State.LOADING);
     if (goog.isDef(options.url)) {
-      this.loadFeaturesFromURL(options.url,
-          /**
-           * @param {Array.<ol.Feature>} features Features.
-           * @this {ol.source.StaticVector}
-           */
-          function(features) {
-            this.addFeaturesInternal(features);
-            this.setState(ol.source.State.READY);
-          }, this);
+      this.loadFeaturesFromURL(options.url, this.onFeaturesLoaded_, this);
     }
     if (goog.isDef(options.urls)) {
       var urls = options.urls;
       var i, ii;
       for (i = 0, ii = urls.length; i < ii; ++i) {
-        this.loadFeaturesFromURL(urls[i],
-            /**
-             * @param {Array.<ol.Feature>} features Features.
-             * @this {ol.source.StaticVector}
-             */
-            function(features) {
-              this.addFeaturesInternal(features);
-              this.setState(ol.source.State.READY);
-            }, this);
+        this.loadFeaturesFromURL(urls[i], this.onFeaturesLoaded_, this);
       }
     }
   }
 
 };
 goog.inherits(ol.source.StaticVector, ol.source.FormatVector);
+
+
+/**
+ * @param {Array.<ol.Feature>} features Features.
+ * @private
+ */
+ol.source.StaticVector.prototype.onFeaturesLoaded_ = function(features) {
+  this.addFeaturesInternal(features);
+  this.setState(ol.source.State.READY);
+};