From 2890a55ee73c38a3cf02defd2e91e8f01fb9f1cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89ric=20Lemoine?= <eric.lemoine@gmail.com>
Date: Wed, 20 Jun 2012 15:13:22 +0200
Subject: [PATCH] [ol.layer.XYZ] a tiling fix

---
 src/ol/layer/XYZ.js            | 20 ++++++++------------
 test/spec/ol/layer/XYZ.test.js |  3 +--
 2 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/src/ol/layer/XYZ.js b/src/ol/layer/XYZ.js
index 60dc65d660..d9ff88ef89 100644
--- a/src/ol/layer/XYZ.js
+++ b/src/ol/layer/XYZ.js
@@ -130,26 +130,22 @@ ol.layer.XYZ.prototype.getData = function(bounds, resolution) {
         offsetY = Math.floor(
                       (tileOriginY - boundsMaxY) / tileHeightGeo),
 
-        gridWidth = Math.ceil(
-                        (boundsMaxX - boundsMinX) / tileWidthGeo),
-        gridHeight = Math.ceil(
-                        (boundsMaxY - boundsMinY) / tileHeightGeo);
+        gridLeft = tileOriginX + tileWidthGeo * offsetX,
+        gridTop = tileOriginY - tileHeightGeo * offsetY;
 
-    var tiles = [],
-        tile,
-        url,
-        i, ii,
-        j, jj;
-
-    for (i=0, ii=gridWidth; i<ii; i++) {
+    var tiles = [], tile, url, i = 0, j;
+    while (gridTop - (i * tileHeightGeo) > boundsMinY) {
         tiles[i] = [];
-        for (j=0, jj=gridHeight; j<jj; j++) {
+        j = 0;
+        while (gridLeft + (j * tileWidthGeo) < boundsMaxX) {
             url = me.url_.replace('{x}', offsetX + i + '')
                          .replace('{y}', offsetY + j + '')
                          .replace('{z}', zoom);
             tile = new ol.Tile(url);
             tiles[i][j] = tile;
+            j++;
         }
+        i++;
     }
 
     return new ol.TileSet(tiles, tileWidth, tileHeight, resolution);
diff --git a/test/spec/ol/layer/XYZ.test.js b/test/spec/ol/layer/XYZ.test.js
index 5c5f618d09..d8b595fedc 100644
--- a/test/spec/ol/layer/XYZ.test.js
+++ b/test/spec/ol/layer/XYZ.test.js
@@ -64,7 +64,6 @@ describe('ol.layer.XYZ', function() {
             });
         });
 
-        /*
         describe('extent -64,-64,64,64, resolution 0.5', function() {
 
             it('returns the expected data', function() {
@@ -94,6 +93,6 @@ describe('ol.layer.XYZ', function() {
                 expect(tile.getImg()).toBeDefined();
             });
         });
-        */
+
     });
 });