ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#645 - layer.removeFeatures backs through the features array to ensure that all features are removed

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3036 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2007-04-09 15:29:31 +00:00
parent 1603d5a8ba
commit 26925a89f1
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/OpenLayers/Layer/Vector.js
View File

@@ -254,7 +254,7 @@ OpenLayers.Layer.Vector.prototype =
features = [features]; features = [features];
} }
for (var i = 0; i < features.length; i++) { for (var i = features.length - 1; i >= 0; i--) {
var feature = features[i]; var feature = features[i];
this.features = OpenLayers.Util.removeItem(this.features, feature); this.features = OpenLayers.Util.removeItem(this.features, feature);

4
tests/Layer/test_Vector.html
View File

@@ -30,7 +30,7 @@
} }
function test_03_Layer_Vector_removeFeatures(t) { function test_03_Layer_Vector_removeFeatures(t) {
t.plan(1); t.plan(2);
var layer = new OpenLayers.Layer.Vector(name); var layer = new OpenLayers.Layer.Vector(name);
@@ -43,13 +43,11 @@
var features = layer.removeFeatures([pointFeature1]); var features = layer.removeFeatures([pointFeature1]);
t.ok(layer.features.length == 1, "OpenLayers.Layer.Vector.removeFeatures removes a feature from the features array"); t.ok(layer.features.length == 1, "OpenLayers.Layer.Vector.removeFeatures removes a feature from the features array");
/* patch for #645 will include this
layer.addFeatures([pointFeature1.clone(), pointFeature2.clone()]); layer.addFeatures([pointFeature1.clone(), pointFeature2.clone()]);
var features = layer.removeFeatures(layer.features); var features = layer.removeFeatures(layer.features);
t.ok(layer.features.length == 0, t.ok(layer.features.length == 0,
"OpenLayers.Layer.Vector.removeFeatures(layer.features) removes all feature from the features array"); "OpenLayers.Layer.Vector.removeFeatures(layer.features) removes all feature from the features array");
*/
} }
function test_Layer_Vector_addStyle (t) { function test_Layer_Vector_addStyle (t) {