From 268c18988b70bb6653780f1f9db6db103541dc19 Mon Sep 17 00:00:00 2001 From: Tom Payne Date: Tue, 21 May 2013 12:47:45 +0200 Subject: [PATCH] Remove unused variables in parsers --- src/ol/parser/ogc/gml_v3.js | 2 +- test/spec/ol/parser/kml.test.js | 6 +++--- test/spec/ol/parser/ogc/gml_v2.test.js | 2 +- test/spec/ol/parser/ogc/gml_v3.test.js | 3 +-- test/spec/ol/parser/ogc/versioned.test.js | 3 --- 5 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/ol/parser/ogc/gml_v3.js b/src/ol/parser/ogc/gml_v3.js index 8162979062..744d75afc8 100644 --- a/src/ol/parser/ogc/gml_v3.js +++ b/src/ol/parser/ogc/gml_v3.js @@ -119,7 +119,7 @@ ol.parser.ogc.GML_v3 = function(opt_options) { var dim = obj.srsDimension || parseInt(node.getAttribute('srsDimension') || node.getAttribute('dimension'), 10) || 2; - var j, x, y, z; + var x, y, z; var numPoints = coords.length / dim; var points = new Array(numPoints); for (var i = 0, ii = coords.length; i < ii; i += dim) { diff --git a/test/spec/ol/parser/kml.test.js b/test/spec/ol/parser/kml.test.js index 2b13914fef..f6f45cc94b 100644 --- a/test/spec/ol/parser/kml.test.js +++ b/test/spec/ol/parser/kml.test.js @@ -49,7 +49,7 @@ describe('ol.parser.kml', function() { afterLoadXml(url, function(xml) { var p = new ol.parser.KML({maxDepth: 1}); // we need to supply a callback to get visited NetworkLinks - var obj = p.read(xml, function(features) { + p.read(xml, function(features) { expect(features.length).to.eql(3); done(); }); @@ -60,7 +60,7 @@ describe('ol.parser.kml', function() { afterLoadXml(url, function(xml) { var p = new ol.parser.KML({maxDepth: 2}); // we need to supply a callback to get visited NetworkLinks - var obj = p.read(xml, function(features) { + p.read(xml, function(features) { expect(features.length).to.eql(2); done(); }); @@ -71,7 +71,7 @@ describe('ol.parser.kml', function() { afterLoadXml(url, function(xml) { var p = new ol.parser.KML({maxDepth: 1}); // we need to supply a callback to get visited NetworkLinks - var obj = p.read(xml, function(features) { + p.read(xml, function(features) { // since maxDepth is 1, we will not get to the second feature expect(features.length).to.eql(1); done(); diff --git a/test/spec/ol/parser/ogc/gml_v2.test.js b/test/spec/ol/parser/ogc/gml_v2.test.js index 1364e3d18c..6e707fcf69 100644 --- a/test/spec/ol/parser/ogc/gml_v2.test.js +++ b/test/spec/ol/parser/ogc/gml_v2.test.js @@ -298,7 +298,7 @@ describe('ol.parser.gml_v2', function() { it('Test boundedBy', function() { var url = 'spec/ol/parser/ogc/xml/gml_v2/boundedBy.xml'; afterLoadXml(url, function(xml) { - var obj = parser.read(xml); + parser.read(xml); // TODO test bounds on feature // see https://github.com/openlayers/ol3/issues/566 }); diff --git a/test/spec/ol/parser/ogc/gml_v3.test.js b/test/spec/ol/parser/ogc/gml_v3.test.js index 48ccf1d643..a89de26b70 100644 --- a/test/spec/ol/parser/ogc/gml_v3.test.js +++ b/test/spec/ol/parser/ogc/gml_v3.test.js @@ -308,8 +308,7 @@ describe('ol.parser.gml_v3', function() { it('Read autoConfig', function() { var url = 'spec/ol/parser/ogc/xml/gml_v3/topp-states-wfs.xml'; afterLoadXml(url, function(xml) { - var obj = parser.read(xml); - var features = obj.features; + parser.read(xml); expect(parser.featureType).to.eql('states'); expect(parser.featureNS).to.eql('http://www.openplans.org/topp'); expect(parser.autoConfig === true).to.be.ok(); diff --git a/test/spec/ol/parser/ogc/versioned.test.js b/test/spec/ol/parser/ogc/versioned.test.js index 1d6173cd4a..ff0d08930c 100644 --- a/test/spec/ol/parser/ogc/versioned.test.js +++ b/test/spec/ol/parser/ogc/versioned.test.js @@ -2,9 +2,6 @@ goog.provide('ol.test.parser.ogc.Versioned'); describe('ol.parser.ogc.versioned', function() { - var snippet = ''; - var snippet2 = ''; - describe('test constructor', function() { var parser = new ol.parser.ogc.Versioned({version: '1.0.0'}); it('new OpenLayers.Format.XML.VersionedOGC returns object', function() {