From 271487c1bca441f8ec0945c3a2933f256ab386e4 Mon Sep 17 00:00:00 2001 From: Tom Payne Date: Wed, 12 Mar 2014 19:52:10 +0100 Subject: [PATCH 1/2] Remove leading whitespace --- src/ol/collection.js | 1 - src/ol/interaction/touchinteraction.js | 1 - src/ol/kinetic.js | 1 - src/ol/object.js | 1 - 4 files changed, 4 deletions(-) diff --git a/src/ol/collection.js b/src/ol/collection.js index 4ef1849391..f8e44f08b0 100644 --- a/src/ol/collection.js +++ b/src/ol/collection.js @@ -1,4 +1,3 @@ - /** * An implementation of Google Maps' MVCArray. * @see https://developers.google.com/maps/documentation/javascript/reference diff --git a/src/ol/interaction/touchinteraction.js b/src/ol/interaction/touchinteraction.js index 987cbb4e29..e30da97b58 100644 --- a/src/ol/interaction/touchinteraction.js +++ b/src/ol/interaction/touchinteraction.js @@ -1,4 +1,3 @@ - goog.provide('ol.interaction.Touch'); goog.require('goog.asserts'); diff --git a/src/ol/kinetic.js b/src/ol/kinetic.js index 56833aed1b..6be0b123f9 100644 --- a/src/ol/kinetic.js +++ b/src/ol/kinetic.js @@ -1,4 +1,3 @@ - goog.provide('ol.Kinetic'); goog.require('ol.Coordinate'); diff --git a/src/ol/object.js b/src/ol/object.js index 59f8f54f88..2b09635a32 100644 --- a/src/ol/object.js +++ b/src/ol/object.js @@ -1,4 +1,3 @@ - /** * An implementation of Google Maps' MVCObject. * @see https://developers.google.com/maps/articles/mvcfun From 9bd49e985eee68ad49d58f5d91e00b8fb7329eff Mon Sep 17 00:00:00 2001 From: Tom Payne Date: Wed, 12 Mar 2014 19:52:38 +0100 Subject: [PATCH 2/2] Add leading whitespace check --- build.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/build.py b/build.py index 8621391bec..7962522c69 100755 --- a/build.py +++ b/build.py @@ -582,6 +582,7 @@ def build_check_requires_timestamp(t): precious=True) def build_check_whitespace_timestamp(t): CR_RE = re.compile(r'\r') + LEADING_WHITESPACE_RE = re.compile(r'\s+') TRAILING_WHITESPACE_RE = re.compile(r'\s+\n\Z') NO_NEWLINE_RE = re.compile(r'[^\n]\Z') ALL_WHITESPACE_RE = re.compile(r'\s+\Z') @@ -589,6 +590,9 @@ def build_check_whitespace_timestamp(t): for filename in sorted(t.newer(t.dependencies)): whitespace = False for lineno, line in enumerate(open(filename, 'rU')): + if lineno == 0 and LEADING_WHITESPACE_RE.match(line): + t.info('%s:%d: leading whitespace', filename, lineno + 1) + errors += 1 if CR_RE.search(line): t.info('%s:%d: carriage return character in line', filename, lineno + 1) errors += 1