From 2467940cd3abf6d1163b86d932e66b699eedf9fe Mon Sep 17 00:00:00 2001 From: crschmidt Date: Thu, 7 Dec 2006 21:18:24 +0000 Subject: [PATCH] A fix for #440. Prevent people who somehow get a null element in the event cache from shooting themselves in the foot: This doesn't seem to happen often, but it has happened in internal code. I'm going to add more debugging info to #440 as we get it, but want to get this in to prevent people from shooting themselves in the foot in IE accidentally. git-svn-id: http://svn.openlayers.org/trunk/openlayers@2024 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf --- lib/OpenLayers/Events.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/OpenLayers/Events.js b/lib/OpenLayers/Events.js index 3ef1e53d8b..ac6151139e 100644 --- a/lib/OpenLayers/Events.js +++ b/lib/OpenLayers/Events.js @@ -96,9 +96,9 @@ OpenLayers.Event = { || element.detachEvent)) name = 'keydown'; - if (element.removeEventListener) { + if (element && element.removeEventListener) { element.removeEventListener(name, observer, useCapture); - } else if (element.detachEvent) { + } else if (element && element.detachEvent) { element.detachEvent('on' + name, observer); } }