ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Lint

Browse Source
This commit is contained in:
Tim Schaub
2014-07-06 12:45:55 -06:00
parent 7e8551a767
commit 21878ebad3
1 changed files with 36 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/test-extensions.js
+36 -21
View File
@@ -105,40 +105,45 @@
} else if (child.nodeType == 3) { } else if (child.nodeType == 3) {
// text node, add if non empty // text node, add if non empty
if (child.nodeValue && if (child.nodeValue &&
child.nodeValue.replace(/^\s*(.*?)\s*$/, '$1') != '') { child.nodeValue.replace(/^\s*(.*?)\s*$/, '$1') !== '') {
nodes.push(child); nodes.push(child);
} }
} }
} }
return nodes; return nodes;
} }
}; }
function assertElementNodesEqual(node1, node2, options, errors) { function assertElementNodesEqual(node1, node2, options, errors) {
var testPrefix = (options && options.prefix === true); var testPrefix = (options && options.prefix === true);
try { try {
expect(node1.nodeType).to.equal(node2.nodeType); expect(node1.nodeType).to.equal(node2.nodeType);
} catch(e) { } catch(e) {
errors.push('nodeType test failed for: ' + node1.nodeName + ' | ' + node2.nodeName + ' | ' + e.message); errors.push('nodeType test failed for: ' + node1.nodeName + ' | ' +
node2.nodeName + ' | ' + e.message);
} }
if (testPrefix) { if (testPrefix) {
try { try {
expect(node1.nodeName).to.equal(node2.nodeName); expect(node1.nodeName).to.equal(node2.nodeName);
} catch(e) { } catch(e) {
errors.push('nodeName test failed for: ' + node1.nodeName + ' | ' + node2.nodeName + ' | ' + e.message); errors.push('nodeName test failed for: ' + node1.nodeName + ' | ' +
node2.nodeName + ' | ' + e.message);
} }
} else { } else {
try { try {
expect(node1.nodeName.split(':').pop()).to.equal(node2.nodeName.split(':').pop()); expect(node1.nodeName.split(':').pop()).to.equal(
node2.nodeName.split(':').pop());
} catch(e) { } catch(e) {
errors.push('nodeName test failed for: ' + node1.nodeName + ' | ' + node2.nodeName + ' | ' + e.message); errors.push('nodeName test failed for: ' + node1.nodeName + ' | ' +
node2.nodeName + ' | ' + e.message);
} }
} }
// for text nodes compare value // for text nodes compare value
if (node1.nodeType === 3) { if (node1.nodeType === 3) {
try { try {
// TODO should we make this optional? // TODO should we make this optional?
expect(node1.nodeValue.replace(/\s/g, '')).to.equal(node2.nodeValue.replace(/\s/g, '')); expect(node1.nodeValue.replace(/\s/g, '')).to.equal(
node2.nodeValue.replace(/\s/g, ''));
} catch(e) { } catch(e) {
errors.push('nodeValue test failed | ' + e.message); errors.push('nodeValue test failed | ' + e.message);
} }
@@ -151,7 +156,8 @@
try { try {
expect(node1.prefix).to.equal(node2.prefix); expect(node1.prefix).to.equal(node2.prefix);
} catch(e) { } catch(e) {
errors.push('Prefix test failed for: ' + node1.nodeName + ' | ' + e.message); errors.push('Prefix test failed for: ' + node1.nodeName + ' | ' +
e.message);
} }
} }
} }
@@ -159,7 +165,8 @@
try { try {
expect(node1.namespaceURI).to.equal(node2.namespaceURI); expect(node1.namespaceURI).to.equal(node2.namespaceURI);
} catch(e) { } catch(e) {
errors.push('namespaceURI test failed for: ' + node1.nodeName + ' | ' + e.message); errors.push('namespaceURI test failed for: ' + node1.nodeName +
' | ' + e.message);
} }
} }
// compare attributes - disregard xmlns given namespace handling above // compare attributes - disregard xmlns given namespace handling above
@@ -196,26 +203,32 @@
try { try {
expect(node1AttrLen).to.equal(node2AttrLen); expect(node1AttrLen).to.equal(node2AttrLen);
} catch(e) { } catch(e) {
errors.push('Number of attributes test failed for: ' + node1.nodeName + ' | ' + e.message); errors.push('Number of attributes test failed for: ' + node1.nodeName +
' | ' + e.message);
} }
var gv, ev; var gv, ev;
for (var name in node1Attr) { for (var name in node1Attr) {
if (node2Attr[name] === undefined) { if (node2Attr[name] === undefined) {
errors.push('Attribute name ' + node1Attr[name].name + ' expected for element ' + node1.nodeName); errors.push('Attribute name ' + node1Attr[name].name +
' expected for element ' + node1.nodeName);
} }
// test attribute namespace // test attribute namespace
try { try {
// we do not care about the difference between an empty string and null for namespaceURI // we do not care about the difference between an empty string and
// some tests will fail in IE9 otherwise // null for namespaceURI some tests will fail in IE9 otherwise
// see also http://msdn.microsoft.com/en-us/library/ff460650(v=vs.85).aspx // see also
expect(node1Attr[name].namespaceURI || null).to.be(node2Attr[name].namespaceURI || null); // http://msdn.microsoft.com/en-us/library/ff460650(v=vs.85).aspx
expect(node1Attr[name].namespaceURI || null).to.be(
node2Attr[name].namespaceURI || null);
} catch(e) { } catch(e) {
errors.push('namespaceURI attribute test failed for: ' + node1.nodeName + ' | ' + e.message); errors.push('namespaceURI attribute test failed for: ' +
node1.nodeName + ' | ' + e.message);
} }
try { try {
expect(node1Attr[name].value).to.equal(node2Attr[name].value); expect(node1Attr[name].value).to.equal(node2Attr[name].value);
} catch(e) { } catch(e) {
errors.push('Attribute value test failed for: ' + node1.nodeName + ' | ' + e.message); errors.push('Attribute value test failed for: ' + node1.nodeName +
' | ' + e.message);
} }
} }
// compare children // compare children
@@ -224,16 +237,18 @@
try { try {
expect(node1ChildNodes.length).to.equal(node2ChildNodes.length); expect(node1ChildNodes.length).to.equal(node2ChildNodes.length);
} catch(e) { } catch(e) {
errors.push('Number of childNodes test failed for: ' + node1.nodeName + ' | ' + e.message); errors.push('Number of childNodes test failed for: ' + node1.nodeName +
' | ' + e.message);
} }
// only compare if they are equal // only compare if they are equal
if (node1ChildNodes.length === node2ChildNodes.length) { if (node1ChildNodes.length === node2ChildNodes.length) {
for (var j=0, jj=node1ChildNodes.length; j<jj; ++j) { for (var j=0, jj=node1ChildNodes.length; j<jj; ++j) {
assertElementNodesEqual(node1ChildNodes[j], node2ChildNodes[j], options, errors); assertElementNodesEqual(
node1ChildNodes[j], node2ChildNodes[j], options, errors);
} }
} }
} }
}; }
/** /**
@@ -259,7 +274,7 @@
function() { function() {
return 'expected ' + expect.stringify(this.obj) + return 'expected ' + expect.stringify(this.obj) +
' to sort of not equal ' + expect.stringify(obj) + '\n' + ' to sort of not equal ' + expect.stringify(obj) + '\n' +
errors.join('\n') errors.join('\n');
}); });
return this; return this;
}; };