ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #4078 from fredj/jscomp_error

Browse Source 
Enable all the compiler checks
This commit is contained in:
Frédéric Junod
2015-09-07 15:32:43 +02:00
parent 9b738b6cb6 4aa2369244
commit 1e78c45466
6 changed files with 22 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/example.json
+6 -32
View File
@@ -14,6 +14,7 @@
"externs/bingmaps.js", "externs/bingmaps.js",
"externs/bootstrap.js", "externs/bootstrap.js",
"externs/closure-compiler.js", "externs/closure-compiler.js",
"externs/esrijson.js",
"externs/example.js", "externs/example.js",
"externs/fastclick.js", "externs/fastclick.js",
"externs/geojson.js", "externs/geojson.js",
@@ -29,40 +30,13 @@
"goog.DEBUG=false" "goog.DEBUG=false"
], ],
"jscomp_error": [ "jscomp_error": [
"accessControls", "*"
"ambiguousFunctionDecl",
"checkEventfulObjectDisposal",
"checkRegExp",
"checkTypes",
"checkVars",
"const",
"constantProperty",
"deprecated",
"duplicateMessage",
"es3",
"es5Strict",
"externsValidation",
"fileoverviewTags",
"globalThis",
"internetExplorerChecks",
"invalidCasts",
"misplacedTypeAnnotation",
"missingGetCssName",
"missingProperties",
"missingProvide",
"missingRequire",
"missingReturn",
"newCheckTypes",
"nonStandardJsDocs",
"suspiciousCode",
"strictModuleDepCheck",
"typeInvalidation",
"undefinedNames",
"undefinedVars",
"uselessCode",
"visibility"
], ],
"jscomp_off": [ "jscomp_off": [
"useOfGoogBase",
"unnecessaryCasts",
"lintChecks",
"missingProvide",
"unknownDefines" "unknownDefines"
], ],
"extra_annotation_name": [ "extra_annotation_name": [
config/examples-all.json
+6 -33
View File
@@ -30,39 +30,12 @@
"goog.DEBUG=false" "goog.DEBUG=false"
], ],
"jscomp_error": [ "jscomp_error": [
"accessControls", "*"
"ambiguousFunctionDecl", ],
"checkEventfulObjectDisposal", "jscomp_off": [
"checkRegExp", "useOfGoogBase",
"checkTypes", "unnecessaryCasts",
"checkVars", "lintChecks"
"const",
"constantProperty",
"deprecated",
"duplicateMessage",
"es3",
"es5Strict",
"externsValidation",
"fileoverviewTags",
"globalThis",
"internetExplorerChecks",
"invalidCasts",
"misplacedTypeAnnotation",
"missingGetCssName",
"missingProperties",
"missingProvide",
"missingRequire",
"missingReturn",
"newCheckTypes",
"nonStandardJsDocs",
"suspiciousCode",
"strictModuleDepCheck",
"typeInvalidation",
"undefinedNames",
"undefinedVars",
"unknownDefines",
"uselessCode",
"visibility"
], ],
"extra_annotation_name": [ "extra_annotation_name": [
"api", "observable" "api", "observable"
config/ol.json
+6 -33
View File
@@ -20,39 +20,12 @@
"goog.DEBUG=false" "goog.DEBUG=false"
], ],
"jscomp_error": [ "jscomp_error": [
"accessControls", "*"
"ambiguousFunctionDecl", ],
"checkEventfulObjectDisposal", "jscomp_off": [
"checkRegExp", "useOfGoogBase",
"checkTypes", "unnecessaryCasts",
"checkVars", "lintChecks"
"const",
"constantProperty",
"deprecated",
"duplicateMessage",
"es3",
"es5Strict",
"externsValidation",
"fileoverviewTags",
"globalThis",
"internetExplorerChecks",
"invalidCasts",
"misplacedTypeAnnotation",
"missingGetCssName",
"missingProperties",
"missingProvide",
"missingRequire",
"missingReturn",
"newCheckTypes",
"nonStandardJsDocs",
"suspiciousCode",
"strictModuleDepCheck",
"typeInvalidation",
"undefinedNames",
"undefinedVars",
"unknownDefines",
"uselessCode",
"visibility"
], ],
"extra_annotation_name": [ "extra_annotation_name": [
"api", "observable" "api", "observable"
examples/shaded-relief.js
+1 -1
View File
@@ -13,7 +13,7 @@ goog.require('ol.source.XYZ');
* neighborhood for determining slope and aspect. * neighborhood for determining slope and aspect.
* @param {Array.<ImageData>} inputs Array of input images. * @param {Array.<ImageData>} inputs Array of input images.
* @param {Object} data Data added in the "beforeoperations" event. * @param {Object} data Data added in the "beforeoperations" event.
* @return {Array.<ImageData>} Output images (only the first is rendered). * @return {ImageData} Output image.
*/ */
function shade(inputs, data) { function shade(inputs, data) {
var elevationImage = inputs[0]; var elevationImage = inputs[0];
src/ol/format/wmscapabilitiesformat.js
+2 -2
View File
@@ -157,10 +157,10 @@ ol.format.WMSCapabilities.readEXGeographicBoundingBox_ =
!goog.isDef(eastBoundLongitude) || !goog.isDef(northBoundLatitude)) { !goog.isDef(eastBoundLongitude) || !goog.isDef(northBoundLatitude)) {
return undefined; return undefined;
} }
return [ return /** @type {ol.Extent} */ ([
westBoundLongitude, southBoundLatitude, westBoundLongitude, southBoundLatitude,
eastBoundLongitude, northBoundLatitude eastBoundLongitude, northBoundLatitude
]; ]);
}; };
tasks/generate-exports.js
+1 -1
View File
@@ -175,7 +175,7 @@ function generateExports(symbols, namespace) {
blocks.unshift( blocks.unshift(
'/**\n' + '/**\n' +
' * @fileoverview Custom exports file.\n' + ' * @fileoverview Custom exports file.\n' +
' * @suppress {checkVars}\n' + ' * @suppress {checkVars,extraRequire}\n' +
' */\n'); ' */\n');
return blocks.join('\n'); return blocks.join('\n');
} }