#611: let all geometry inherit toString from the superclass - geometry.toString returns well-known text based on Format.WKT.write()

git-svn-id: http://svn.openlayers.org/trunk/openlayers@2945 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Format/WKT.js

@@ -69,6 +69,9 @@ OpenLayers.Format.WKT.prototype =
             }
             geometry = collection[i];
             type = geometry.CLASS_NAME.split('.')[2].toLowerCase();
+            if(!this.extract[type]) {
+                return null;
+            }
             data = this.extract[type].apply(this, [geometry]);
             pieces.push(type.toUpperCase() + '(' + data + ')');
         }

lib/OpenLayers/Geometry.js

@@ -4,6 +4,7 @@
  
 /**
  * @class
+ * @requires OpenLayers/Format/WKT.js
  */
 OpenLayers.Geometry = OpenLayers.Class.create();
 OpenLayers.Geometry.prototype = {
@@ -160,6 +161,14 @@ OpenLayers.Geometry.prototype = {
         return 0.0;
     },
 
+    /**
+     * @returns the Well-Known Text representation of a geometry
+     * @type String
+     */
+    toString: function() {
+       return OpenLayers.Format.WKT.prototype.write(this);
+    },
+
     /** @final @type String */
     CLASS_NAME: "OpenLayers.Geometry"
 };

lib/OpenLayers/Geometry/Collection.js

@@ -54,15 +54,6 @@ OpenLayers.Geometry.Collection.prototype =
         this.components = null;
     },
 
-    /**
-     * @returns The coordinates components as a string
-     * @type String
-     */
-    toString: function() {
-        return this.components.toString();
-    },
-    
-
     /**
      * @returns An exact clone of this collection
      * @type OpenLayers.Geometry.Collection

lib/OpenLayers/Geometry/Point.js

@@ -85,14 +85,6 @@ OpenLayers.Geometry.Point.prototype =
         return equals;
     },
     
-    /**
-     * @returns the coordinates as a string
-     * @type String
-     */
-    toString: function() {
-       return this.toShortString();
-    },
-    
     /**
      * @return Shortened String representation of Point object. 
      *         (ex. <i>"5, 42"</i>)

tests/Geometry/test_LineString.html

@@ -28,7 +28,9 @@
         t.plan(1);
         
         line = new OpenLayers.Geometry.LineString(components);
-        t.eq( line.toString(), components.toString(), "toString output checks in");
+        t.eq(line.toString(),
+             "LINESTRING(10 15,0 0)",
+             "toString() returns WKT");
     }
     
     function test_03_LineString_removeComponent(t) {
@@ -56,7 +58,9 @@
     function test_04_LineString_move(t) {
         t.plan(4);
         
-        line = new OpenLayers.Geometry.LineString(components);
+        var components = [new OpenLayers.Geometry.Point(10,15), 
+                new OpenLayers.Geometry.Point(0,0)];
+        var line = new OpenLayers.Geometry.LineString(components);
         
         var x0 = components[0].x;
         var y0 = components[0].y;

tests/Geometry/test_LinearRing.html

@@ -97,13 +97,6 @@
         t.eq(ring.getArea(), 100, "getArea works lovely");
     }
 
-    function test_05_LinearRing_toString(t) {
-        t.plan(1);
-        
-        ring = new OpenLayers.Geometry.LinearRing(components);
-        t.eq( ring.toString(), components.toString() + ',' + components[0].toString(), "toString output is ok");
-    }
-
   // -->
   </script>
 </head>

tests/Geometry/test_Point.html

@@ -60,7 +60,8 @@
         var y = 20;
         point = new OpenLayers.Geometry.Point(x, y);
         bounds = point.getBounds();
-        t.eq( point.toString(), x + ", " + y, "toString() works" );
+        t.eq(point.toString(), "POINT(" + x + " " + y + ")",
+             "toString() returns WKT" );
         
     }