From 6cd1f3f2627d73662b20ace846894c7fb72e1586 Mon Sep 17 00:00:00 2001
From: Bart van den Eijnden <bartvde@boundlessgeo.com>
Date: Sat, 29 Nov 2014 12:31:33 +0100
Subject: [PATCH] Correct olx.style.RegularShapeOptions definition

---
 externs/olx.js                    | 16 ++++++++--------
 src/ol/style/regularshapestyle.js |  7 ++++++-
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/externs/olx.js b/externs/olx.js
index 5b871832f1..e850627709 100644
--- a/externs/olx.js
+++ b/externs/olx.js
@@ -5656,10 +5656,10 @@ olx.style.IconOptions.prototype.src;
  * Specify radius for regular polygons, or radius1 and radius2 for stars.
  * @typedef {{fill: (ol.style.Fill|undefined),
  *     points: number,
- *     radius: number,
- *     radius1: number,
- *     radius2: number,
- *     angle: number,
+ *     radius: (number|undefined),
+ *     radius1: (number|undefined),
+ *     radius2: (number|undefined),
+ *     angle: (number|undefined),
  *     snapToPixel: (boolean|undefined),
  *     stroke: (ol.style.Stroke|undefined)}}
  * @api
@@ -5686,7 +5686,7 @@ olx.style.RegularShapeOptions.prototype.points;
 
 /**
  * Radius of a regular polygon.
- * @type {number}
+ * @type {number|undefined}
  * @api
  */
 olx.style.RegularShapeOptions.prototype.radius;
@@ -5694,7 +5694,7 @@ olx.style.RegularShapeOptions.prototype.radius;
 
 /**
 * Inner radius of a star.
-* @type {number}
+* @type {number|undefined}
 * @api
 */
 olx.style.RegularShapeOptions.prototype.radius1;
@@ -5702,7 +5702,7 @@ olx.style.RegularShapeOptions.prototype.radius1;
 
 /**
  * Outer radius of a star.
- * @type {number}
+ * @type {number|undefined}
  * @api
  */
 olx.style.RegularShapeOptions.prototype.radius2;
@@ -5712,7 +5712,7 @@ olx.style.RegularShapeOptions.prototype.radius2;
  * Shape's rotation in radians. A value of 0 will have one of the shape's point
  * facing up.
  * Default value is 0.
- * @type {number}
+ * @type {number|undefined}
  * @api
  */
 olx.style.RegularShapeOptions.prototype.angle;
diff --git a/src/ol/style/regularshapestyle.js b/src/ol/style/regularshapestyle.js
index 07028e1f77..579e71f6f7 100644
--- a/src/ol/style/regularshapestyle.js
+++ b/src/ol/style/regularshapestyle.js
@@ -1,5 +1,6 @@
 goog.provide('ol.style.RegularShape');
 
+goog.require('goog.asserts');
 goog.require('goog.dom');
 goog.require('goog.dom.TagName');
 goog.require('ol.color');
@@ -58,11 +59,15 @@ ol.style.RegularShape = function(opt_options) {
    */
   this.points_ = options.points;
 
+  goog.asserts.assert(goog.isDef(options.radius) ||
+      goog.isDef(options.radius1));
+
   /**
    * @private
    * @type {number}
    */
-  this.radius_ = goog.isDef(options.radius) ? options.radius : options.radius1;
+  this.radius_ = /** @type {number} */ (goog.isDef(options.radius) ?
+      options.radius : options.radius1);
 
   /**
    * @private