From 1850e16bde32365f1ad6d4b03109d1ab0d58af0b Mon Sep 17 00:00:00 2001 From: Denis <51781722+rycgar@users.noreply.github.com> Date: Wed, 13 Apr 2022 14:11:28 +0200 Subject: [PATCH] Improve jsDoc and some naming --- examples/vector-labels-justify-text.js | 4 ++-- src/ol/render/canvas/Immediate.js | 3 ++- src/ol/render/canvas/TextBuilder.js | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/vector-labels-justify-text.js b/examples/vector-labels-justify-text.js index c752859d0a..f32b28e10e 100644 --- a/examples/vector-labels-justify-text.js +++ b/examples/vector-labels-justify-text.js @@ -59,7 +59,7 @@ const features = [ }, ]; -function createStyleFunction({textAlign, justify}) { +function createStyle({textAlign, justify}) { return new Style({ image: new CircleStyle({ radius: 10, @@ -98,7 +98,7 @@ const vectorPoints = new VectorLayer({ const feature = new Feature({ geometry: featureOptions.geometry, }); - feature.setStyle(createStyleFunction(featureOptions)); + feature.setStyle(createStyle(featureOptions)); return feature; }) ), diff --git a/src/ol/render/canvas/Immediate.js b/src/ol/render/canvas/Immediate.js index 96e8a0261f..543afdef10 100644 --- a/src/ol/render/canvas/Immediate.js +++ b/src/ol/render/canvas/Immediate.js @@ -946,7 +946,8 @@ class CanvasImmediateRenderer extends VectorContext { const textAlign = textState.textAlign ? textState.textAlign : defaultTextAlign; - // Ignore justification here, since rich-text and also `'\n'` make less sense for line placement. + // Ignore `textState.justify` here, + // since rich-text is not supported for the immediate rendering API. if (!contextTextState) { context.font = textState.font; context.textAlign = /** @type {CanvasTextAlign} */ (textAlign); diff --git a/src/ol/render/canvas/TextBuilder.js b/src/ol/render/canvas/TextBuilder.js index 73aa96553d..5f23ee3c58 100644 --- a/src/ol/render/canvas/TextBuilder.js +++ b/src/ol/render/canvas/TextBuilder.js @@ -211,7 +211,8 @@ class CanvasTextBuilder extends CanvasBuilder { } this.beginGeometry(geometry, feature); const textAlign = textState.textAlign; - // Ignore justification here, since rich-text and also `'\n'` make less sense for line placement. + // Ignore `textState.justify` here, + // since rich-text and also `'\n'` make less sense for line placement. let flatOffset = 0; let flatEnd; for (let o = 0, oo = ends.length; o < oo; ++o) {