ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix calling Overlay.panIntoView with no options

Browse Source 
* API-doc said undefined is OK, code assumed an object
This commit is contained in:
Edward Nash
2020-04-16 16:25:01 +02:00
parent 12043e147c
commit 17a8017e1e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ol/Overlay.js
View File

@@ -408,10 +408,10 @@ class Overlay extends BaseObject {
/** /**
* Pan the map so that the overlay is entirely visible in the current viewport * Pan the map so that the overlay is entirely visible in the current viewport
* (if necessary). * (if necessary).
* @param {PanIntoViewOptions|undefined} panIntoViewOptions Options for the pan action * @param {PanIntoViewOptions|undefined} opt_panIntoViewOptions Options for the pan action
* @api * @api
*/ */
panIntoView(panIntoViewOptions) { panIntoView(opt_panIntoViewOptions) {
const map = this.getMap(); const map = this.getMap();
if (!map || !map.getTargetElement() || !this.get(Property.POSITION)) { if (!map || !map.getTargetElement() || !this.get(Property.POSITION)) {
@@ -425,6 +425,8 @@ class Overlay extends BaseObject {
outerHeight(element), outerHeight(element),
]); ]);
const panIntoViewOptions = opt_panIntoViewOptions || {};
const myMargin = const myMargin =
panIntoViewOptions.margin === undefined ? 20 : panIntoViewOptions.margin; panIntoViewOptions.margin === undefined ? 20 : panIntoViewOptions.margin;
if (!containsExtent(mapRect, overlayRect)) { if (!containsExtent(mapRect, overlayRect)) {