ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #8843 from tonio/ts_fullscreen

Browse Source 
Fix ts typing for fullscreen button
This commit is contained in:
Antoine Abt
2018-10-23 14:18:46 +02:00
committed by GitHub
parent 0cd3e39fe8 fc8ba24d3f
commit 1740f02737
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/ol/control/FullScreen.js
View File

@@ -101,14 +101,19 @@ class FullScreen extends Control {
this.labelActiveNode_ = typeof labelActive === 'string' ? this.labelActiveNode_ = typeof labelActive === 'string' ?
document.createTextNode(labelActive) : labelActive; document.createTextNode(labelActive) : labelActive;
const tipLabel = options.tipLabel ? options.tipLabel : 'Toggle full-screen'; /**
const button = document.createElement('button'); * @private
this.setClassName_(button, isFullScreen()); * @type {HTMLElement}
button.setAttribute('type', 'button'); */
button.title = tipLabel; this.button_ = document.createElement('button');
button.appendChild(this.labelNode_);
listen(button, EventType.CLICK, const tipLabel = options.tipLabel ? options.tipLabel : 'Toggle full-screen';
this.setClassName_(this.button_, isFullScreen());
this.button_.setAttribute('type', 'button');
this.button_.title = tipLabel;
this.button_.appendChild(this.labelNode_);
listen(this.button_, EventType.CLICK,
this.handleClick_, this); this.handleClick_, this);
const cssClasses = this.cssClassName_ + ' ' + CLASS_UNSELECTABLE + const cssClasses = this.cssClassName_ + ' ' + CLASS_UNSELECTABLE +
@@ -116,7 +121,7 @@ class FullScreen extends Control {
(!isFullScreenSupported() ? CLASS_UNSUPPORTED : ''); (!isFullScreenSupported() ? CLASS_UNSUPPORTED : '');
const element = this.element; const element = this.element;
element.className = cssClasses; element.className = cssClasses;
element.appendChild(button); element.appendChild(this.button_);
/** /**
* @private * @private
@@ -176,13 +181,12 @@ class FullScreen extends Control {
* @private * @private
*/ */
handleFullScreenChange_() { handleFullScreenChange_() {
const button = this.element.firstElementChild;
const map = this.getMap(); const map = this.getMap();
if (isFullScreen()) { if (isFullScreen()) {
this.setClassName_(button, true); this.setClassName_(this.button_, true);
replaceNode(this.labelActiveNode_, this.labelNode_); replaceNode(this.labelActiveNode_, this.labelNode_);
} else { } else {
this.setClassName_(button, false); this.setClassName_(this.button_, false);
replaceNode(this.labelNode_, this.labelActiveNode_); replaceNode(this.labelNode_, this.labelActiveNode_);
} }
if (map) { if (map) {