From aa6c5b8a35269175c2c5093927e604a4b908bc85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Harrtell?= Date: Thu, 10 Jan 2013 21:30:09 +0100 Subject: [PATCH 1/2] Default fallThrough to false Default behaviour in OpenLayers 2.12 is to swallow events, even though the documentation says otherwise. --- lib/OpenLayers/Map.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/OpenLayers/Map.js b/lib/OpenLayers/Map.js index 872e31cce5..fae33ea086 100644 --- a/lib/OpenLayers/Map.js +++ b/lib/OpenLayers/Map.js @@ -384,9 +384,9 @@ OpenLayers.Map = OpenLayers.Class({ * APIProperty: fallThrough * {Boolean} Should OpenLayers allow events on the map to fall through to * other elements on the page, or should it swallow them? (#457) - * Default is to fall through. + * Default is to swallow. */ - fallThrough: true, + fallThrough: false, /** * APIProperty: autoUpdateSize From 58e33601bab85faeb98666990e465fb7401ff3e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Harrtell?= Date: Thu, 10 Jan 2013 22:00:48 +0100 Subject: [PATCH 2/2] Update notes/2.13.md --- notes/2.13.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/notes/2.13.md b/notes/2.13.md index 18fc3d833a..84eb0a68cc 100644 --- a/notes/2.13.md +++ b/notes/2.13.md @@ -68,6 +68,19 @@ Corresponding issue/pull requests: * https://github.com/openlayers/openlayers/pull/423 +## Map property fallThrough defaults to false + +The behaviour controlled by map property fallThrough wasn't consistent and changes +has been made to fix that. The change means that some events will fall through as +was intended with fallThrough set to true. Defaulting fallThrough to false after +this change is sensible in most situations and will probably be what most +applications expect, but if you previously relied on events beeing passed through +you will probably want to set fallThrough to true. + +Behavioural change was made in this commit: + +* https://github.com/openlayers/openlayers/commit/a6119f6a7528e013b922fd0d997a07df13f6bd6e + # New Options for Build Script * add the contents of a file as a comment at the front of the build, for example, the output of 'git describe --tags' could be saved as a file and then included