From 4fe157e7fb16e29aa4780d03d3eddf6d6393d77f Mon Sep 17 00:00:00 2001 From: Kai Volland Date: Wed, 25 Sep 2019 15:03:37 +0200 Subject: [PATCH 1/4] Removes invalid description on @type annotation --- src/ol/featureloader.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ol/featureloader.js b/src/ol/featureloader.js index d00bdfe65b..c27cc0fc64 100644 --- a/src/ol/featureloader.js +++ b/src/ol/featureloader.js @@ -6,7 +6,7 @@ import FormatType from './format/FormatType.js'; /** * - * @type {boolean} withCredentials Compare https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/ + * @type {boolean} * @private */ let withCredentials = false; From 7c5f144cf4e8e7af0609f0f86103d36b1b6e0c2a Mon Sep 17 00:00:00 2001 From: Kai Volland Date: Wed, 25 Sep 2019 15:04:49 +0200 Subject: [PATCH 2/4] Removes @fires annotation from LabelCache --- src/ol/render/canvas/LabelCache.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ol/render/canvas/LabelCache.js b/src/ol/render/canvas/LabelCache.js index 578ff22f0b..6442e60330 100644 --- a/src/ol/render/canvas/LabelCache.js +++ b/src/ol/render/canvas/LabelCache.js @@ -8,7 +8,6 @@ import LRUCache from '../../structs/LRUCache.js'; /** * @classdesc * Cache of pre-rendered labels. - * @fires import("../events/Event.js").Event */ class LabelCache extends LRUCache { From 861147547751ae394c8f05a69dbeec038d543d7f Mon Sep 17 00:00:00 2001 From: Kai Volland Date: Wed, 25 Sep 2019 15:05:39 +0200 Subject: [PATCH 3/4] Transforms TEXT_ALIGN enum This transforms the TEXT_ALIGN enum to avoid "empty enum" warning when running jsdoc. --- src/ol/render/canvas/TextBuilder.js | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/ol/render/canvas/TextBuilder.js b/src/ol/render/canvas/TextBuilder.js index 2c8c601441..10cf759148 100644 --- a/src/ol/render/canvas/TextBuilder.js +++ b/src/ol/render/canvas/TextBuilder.js @@ -14,18 +14,19 @@ import TextPlacement from '../../style/TextPlacement.js'; * @const * @enum {number} */ -export const TEXT_ALIGN = {}; -TEXT_ALIGN['left'] = 0; -TEXT_ALIGN['end'] = 0; -TEXT_ALIGN['center'] = 0.5; -TEXT_ALIGN['right'] = 1; -TEXT_ALIGN['start'] = 1; -TEXT_ALIGN['top'] = 0; -TEXT_ALIGN['middle'] = 0.5; -TEXT_ALIGN['hanging'] = 0.2; -TEXT_ALIGN['alphabetic'] = 0.8; -TEXT_ALIGN['ideographic'] = 0.8; -TEXT_ALIGN['bottom'] = 1; +export const TEXT_ALIGN = { + left: 0, + end: 0, + center: 0.5, + right: 1, + start: 1, + top: 0, + middle: 0.5, + hanging: 0.2, + alphabetic: 0.8, + ideographic: 0.8, + bottom: 1 +}; class CanvasTextBuilder extends CanvasBuilder { From 68c052c9d52ba3252e7bac6d9c0bd929c3294afa Mon Sep 17 00:00:00 2001 From: Kai Volland Date: Wed, 25 Sep 2019 15:40:24 +0200 Subject: [PATCH 4/4] Quote keys of TEXT_ALIGN to avoid minifcation --- src/ol/render/canvas/TextBuilder.js | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/ol/render/canvas/TextBuilder.js b/src/ol/render/canvas/TextBuilder.js index 10cf759148..89ec48de68 100644 --- a/src/ol/render/canvas/TextBuilder.js +++ b/src/ol/render/canvas/TextBuilder.js @@ -15,17 +15,17 @@ import TextPlacement from '../../style/TextPlacement.js'; * @enum {number} */ export const TEXT_ALIGN = { - left: 0, - end: 0, - center: 0.5, - right: 1, - start: 1, - top: 0, - middle: 0.5, - hanging: 0.2, - alphabetic: 0.8, - ideographic: 0.8, - bottom: 1 + 'left': 0, + 'end': 0, + 'center': 0.5, + 'right': 1, + 'start': 1, + 'top': 0, + 'middle': 0.5, + 'hanging': 0.2, + 'alphabetic': 0.8, + 'ideographic': 0.8, + 'bottom': 1 };