ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #10332 from ahocevar/no-touch-action-css

Browse Source 
Conditional default prevention instead of touch-action: none
This commit is contained in:
Andreas Hocevar
2019-11-29 09:52:29 +01:00
committed by GitHub
parent 0a319ea2a2 88b8b2f7cb
commit 10a6284b0b
10 changed files with 103 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/spec/ol/MapBrowserEventHandler.test.js
View File

@@ -174,4 +174,21 @@ describe('ol/MapBrowserEventHandler', function() {
expect(moveToleranceHandler.isMoving_(pointermoveAt2)).to.be(true);
});
});
describe('handleTouchMove_', function() {
let handler;
beforeEach(function() {
handler = new MapBrowserEventHandler(new Map({}));
});
it('prevents default on touchmove event', function() {
handler.originalPointerMoveEvent_ = {
defaultPrevented: true
};
const event = {
preventDefault: sinon.spy()
};
handler.handleTouchMove_(event);
expect(event.preventDefault.callCount).to.be(1);
});
});
});

15
test/spec/ol/map.test.js
View File

@@ -666,21 +666,6 @@ describe('ol.Map', function() {
expect(map.handleResize_).to.be.ok();
});
it('handles touch-action on focus and blur', function() {
expect(map.focusHandlerKeys_).to.be(null);
expect(map.getViewport().getAttribute('touch-action')).to.be('none');
const target = document.createElement('div');
target.setAttribute('tabindex', 1);
map.setTarget(target);
expect(Array.isArray(map.focusHandlerKeys_)).to.be(true);
expect(map.getViewport().getAttribute('touch-action')).to.be('auto');
target.dispatchEvent(new Event('focus'));
expect(map.getViewport().getAttribute('touch-action')).to.be('none');
map.setTarget(null);
expect(map.focusHandlerKeys_).to.be(null);
expect(map.getViewport().getAttribute('touch-action')).to.be('none');
});
describe('call setTarget with null', function() {
it('unregisters the viewport resize listener', function() {
map.setTarget(null);