With dramatic flourish, I'm modifying 21 files with 1033 insertions and 815 deletions between release candidates. This moves all rule subclasses to a more natural home as filter subclasses. Also adds tests for SLD write and corrects a handful of issues there. Apologies to all who lose sleep over this sort of thing. r=ahocevar,crschmidt (closes #1492)

git-svn-id: http://svn.openlayers.org/trunk/openlayers@6818 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

tests/Style.html

@@ -27,20 +27,29 @@
         
         var style = new OpenLayers.Style(baseStyle);
         
-        var rule1 = new OpenLayers.Rule.FeatureId({
-                fids: ["1"],
-                symbolizer: {"Point": {fillColor: "green"}},
-                maxScaleDenominator: 500000});
-        var rule2 = new OpenLayers.Rule.FeatureId({
-                fids: ["1"],
-                symbolizer: {"Point": {fillColor: "yellow"}},
-                minScaleDenominator: 500000,
-                maxScaleDenominator: 1000000});
-        var rule3 = new OpenLayers.Rule.FeatureId({
-                fids: ["1"],
-                symbolizer: {"Point": {fillColor: "red"}},
-                minScaleDenominator: 1000000,
-                maxScaleDenominator: 2500000});
+        var rule1 = new OpenLayers.Rule({
+            symbolizer: {"Point": {fillColor: "green"}},
+            maxScaleDenominator: 500000,
+            filter: new OpenLayers.Filter.FeatureId({
+                fids: ["1"]
+            })
+        });
+        var rule2 = new OpenLayers.Rule({
+            symbolizer: {"Point": {fillColor: "yellow"}},
+            minScaleDenominator: 500000,
+            maxScaleDenominator: 1000000,
+            filter: new OpenLayers.Filter.FeatureId({
+                fids: ["1"]
+            })
+        });
+        var rule3 = new OpenLayers.Rule({
+            symbolizer: {"Point": {fillColor: "red"}},
+            minScaleDenominator: 1000000,
+            maxScaleDenominator: 2500000,
+            filter: new OpenLayers.Filter.FeatureId({
+                fids: ["1"]
+            })
+        });
         
         var feature = new OpenLayers.Feature.Vector(
                 new OpenLayers.Geometry.Point(3,5),
@@ -119,11 +128,14 @@
     
     function test_Style_context(t) {
         t.plan(1);
-        var rule = new OpenLayers.Rule.Comparison({
-            type: OpenLayers.Rule.Comparison.LESS_THAN,
-            property: "size",
-            value: 11,
-            symbolizer: {"Point": {externalGraphic: "${img1}"}}});
+        var rule = new OpenLayers.Rule({
+            symbolizer: {"Point": {externalGraphic: "${img1}"}},
+            filter: new OpenLayers.Filter.Comparison({
+                type: OpenLayers.Filter.Comparison.LESS_THAN,
+                property: "size",
+                value: 11
+            })
+        });
         var style = new OpenLayers.Style();
         style.context = {
             "img1": "myImage.png"