ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix memory leak in CanvasImageRenderer when rendering a VectorLayer with renderMode: 'image'.

Browse Source 
Added tests to CanvasImageLayerRenderer for this issue.
This commit is contained in:
Erin Campbell
2018-03-08 13:52:45 -07:00
parent 8f0ffe2043
commit 0fcc986dac
2 changed files with 74 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
test/spec/ol/renderer/canvas/imagelayer.test.js
View File

@@ -1,12 +1,42 @@
import Map from '../../../../../src/ol/Map.js';
import View from '../../../../../src/ol/View.js';
import ImageLayer from '../../../../../src/ol/layer/Image.js';
import VectorLayer from '../../../../../src/ol/layer/Vector.js';
import Projection from '../../../../../src/ol/proj/Projection.js';
import Static from '../../../../../src/ol/source/ImageStatic.js';
import VectorSource from '../../../../../src/ol/source/Vector.js';
import CanvasImageLayerRenderer from '../../../../../src/ol/renderer/canvas/ImageLayer.js';
import CanvasVectorLayerRenderer from '../../../../../src/ol/renderer/canvas/VectorLayer.js';
describe('ol.renderer.canvas.ImageLayer', function() {
describe('#dispose()', function() {
let layer, imageRenderer, vectorRenderer;
beforeEach(function() {
layer = new VectorLayer({
renderMode: 'image',
source: new VectorSource()
});
imageRenderer = new CanvasImageLayerRenderer(layer);
vectorRenderer = new CanvasVectorLayerRenderer(layer);
});
afterEach(function() {
vectorRenderer.dispose();
imageRenderer.dispose();
layer.dispose();
});
it('cleans up CanvasVectorRenderer', function() {
const spy = sinon.spy(vectorRenderer, 'dispose');
imageRenderer.setVectorRenderer(vectorRenderer);
imageRenderer.dispose();
expect(spy.called).to.be(true);
});
});
describe('#forEachLayerAtCoordinate', function() {
let map, target, source;
@@ -62,4 +92,33 @@ describe('ol.renderer.canvas.ImageLayer', function() {
});
});
describe('#setVectorRenderer()', function() {
let layer, imageRenderer, vectorRenderer1, vectorRenderer2;
beforeEach(function() {
layer = new VectorLayer({
renderMode: 'image',
source: new VectorSource()
});
imageRenderer = new CanvasImageLayerRenderer(layer);
vectorRenderer1 = new CanvasVectorLayerRenderer(layer);
vectorRenderer2 = new CanvasVectorLayerRenderer(layer);
});
afterEach(function() {
vectorRenderer1.dispose();
vectorRenderer2.dispose();
imageRenderer.dispose();
layer.dispose();
});
it('cleans up an existing vectorRenderer', function() {
const spy = sinon.spy(vectorRenderer1, 'dispose');
imageRenderer.setVectorRenderer(vectorRenderer1);
expect(spy.called).to.be(false);
imageRenderer.setVectorRenderer(vectorRenderer2);
expect(spy.called).to.be(true);
});
});
});