ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

using blank image to avoid the "Loading Image" frames on Firefox that were discussed during the review (see #3419)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@12243 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
ahocevar
2011-08-13 08:15:36 +00:00
parent 23c9092201
commit 0daaa12059
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/OpenLayers/Tile/Image.js
View File

@@ -39,7 +39,16 @@ OpenLayers.Tile.Image = OpenLayers.Class(OpenLayers.Tile.BackBufferable, {
*/ */
frame: null, frame: null,
/** /**
* Property: blankImageUrl
* {String} Does not result in a blank image on all browsers, but this is
* only required in some browsers as transparent backgroundImage, or as
* temporary image src while the tile is invisible and loading, so we don't
* care.
*/
blankImageUrl: "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAQAIBRAA7",
/**
* Property: imageReloadAttempts * Property: imageReloadAttempts
* {Integer} Attempts to load the image. * {Integer} Attempts to load the image.
*/ */
@@ -274,10 +283,9 @@ OpenLayers.Tile.Image = OpenLayers.Class(OpenLayers.Tile.BackBufferable, {
* url - {String} or undefined to hide the image * url - {String} or undefined to hide the image
*/ */
setImgSrc: function(url) { setImgSrc: function(url) {
this.imgDiv.style.display = "none"; var img = this.imgDiv;
if (url) { img.style.display = "none";
this.imgDiv.src = url; img.src = url ? url : this.blankImageUrl;
}
}, },
/** /**
@@ -342,4 +350,4 @@ OpenLayers.Tile.Image = OpenLayers.Class(OpenLayers.Tile.BackBufferable, {
CLASS_NAME: "OpenLayers.Tile.Image" CLASS_NAME: "OpenLayers.Tile.Image"
}); });

12
lib/OpenLayers/Tile/Image/IFrame.js
View File

@@ -28,15 +28,7 @@ OpenLayers.Tile.Image.IFrame = {
*/ */
useIFrame: null, useIFrame: null,
/** /**
* Property: blankImageUrl
* {String} This is only used as background image for the eventPane, so we
* don't care that this doesn't actually result in a blank image on all
* browsers
*/
blankImageUrl: "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAQAIBRAA7",
/**
* Method: updateBackBuffer * Method: updateBackBuffer
* Update the <backBufferData>, and return a new or reposition the * Update the <backBufferData>, and return a new or reposition the
* backBuffer. When a backbuffer is returned, the tile's markup is not * backBuffer. When a backbuffer is returned, the tile's markup is not
@@ -193,4 +185,4 @@ OpenLayers.Tile.Image.IFrame = {
} }
} }
}; };