ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GeoRSS fails on large line/poly nodes in FF. Use concatChildNodes to get all

Browse Source 
the text into one string before parsing. Includes manual test. r=ahocevar. 
(Closes #1614) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7871 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
crschmidt
2008-08-26 23:24:44 +00:00
parent 319c8f87ef
commit 091d3cfbeb
3 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/Format/GeoRSS.js
+2 -2
View File
@@ -128,7 +128,7 @@ OpenLayers.Format.GeoRSS = OpenLayers.Class(OpenLayers.Format.XML, {
parseFloat(location[0])); parseFloat(location[0]));
} else if (line.length > 0) { } else if (line.length > 0) {
var coords = OpenLayers.String.trim(line[0].firstChild.nodeValue).split(/\s+/); var coords = OpenLayers.String.trim(this.concatChildValues(line[0])).split(/\s+/);
var components = []; var components = [];
var point; var point;
for (var i=0, len=coords.length; i<len; i+=2) { for (var i=0, len=coords.length; i<len; i+=2) {
@@ -138,7 +138,7 @@ OpenLayers.Format.GeoRSS = OpenLayers.Class(OpenLayers.Format.XML, {
} }
geometry = new OpenLayers.Geometry.LineString(components); geometry = new OpenLayers.Geometry.LineString(components);
} else if (polygon.length > 0) { } else if (polygon.length > 0) {
var coords = OpenLayers.String.trim(polygon[0].firstChild.nodeValue).split(/\s+/); var coords = OpenLayers.String.trim(this.concatChildValues(polygon[0])).split(/\s+/);
var components = []; var components = [];
var point; var point;
for (var i=0, len=coords.length; i<len; i+=2) { for (var i=0, len=coords.length; i<len; i+=2) {
tests/manual/arkansas.rss
+9
View File
File diff suppressed because one or more lines are too long
tests/manual/big-georss.html
+27
View File
@@ -0,0 +1,27 @@
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>OpenLayers GML Layer Example</title>
<link rel="stylesheet" href="../../theme/default/style.css" type="text/css" />
<link rel="stylesheet" href="../../examples/style.css" type="text/css" />
<script src="../../lib/OpenLayers.js"></script>
<script type="text/javascript">
var lon = 5;
var lat = 40;
var zoom = 5;
var map, layer;
function init(){
map = new OpenLayers.Map('map');
layer = new OpenLayers.Layer.WMS( "OpenLayers WMS",
"http://labs.metacarta.com/wms/vmap0", {layers: 'basic'} );
map.addLayer(layer);
map.zoomToExtent(new OpenLayers.Bounds(-94.617035,33.010025,-89.645401,36.492752));
map.addLayer(new OpenLayers.Layer.GML("GML", "arkansas.rss", {format: OpenLayers.Format.GeoRSS}));
}
</script>
</head>
<body onload="init()">
<p>Does this map look like arkansas?</p>
<div id="map" class="smallmap"></div>
</body>
</html>