ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #370 from bbinet/fix-missing-requires

Browse Source 
Fix check for missing goog.require directives
This commit is contained in:
Bruno Binet
2013-03-18 08:16:43 -07:00
parent 40f2dc6322 28155a4147
commit 07fb27db2c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
build.py
View File

@@ -311,7 +311,7 @@ def build_check_requires_timestamp(t):
all_provides.discard('ol') all_provides.discard('ol')
all_provides.discard('ol.Map') all_provides.discard('ol.Map')
all_provides.discard('ol.MapProperty') all_provides.discard('ol.MapProperty')
provide_res = dict((provide, re.compile(r'\b%s\b' % (re.escape(provide)),)) for provide in all_provides) provide_res = [(provide, re.compile(r'\b%s\b' % (re.escape(provide)),)) for provide in sorted(all_provides, reverse=True)]
missing_count = 0 missing_count = 0
for filename in sorted(t.dependencies): for filename in sorted(t.dependencies):
if filename in INTERNAL_SRC or filename in EXTERNAL_SRC: if filename in INTERNAL_SRC or filename in EXTERNAL_SRC:
@@ -328,8 +328,9 @@ def build_check_requires_timestamp(t):
if m: if m:
requires.add(m.group(1)) requires.add(m.group(1))
continue continue
for provide, provide_re in provide_res.iteritems(): for provide, provide_re in provide_res:
if provide_re.search(line): if provide_re.search(line):
line = line.replace(provide, '')
uses.add(provide) uses.add(provide)
if filename == 'src/ol/renderer/layerrenderer.js': if filename == 'src/ol/renderer/layerrenderer.js':
uses.discard('ol.renderer.Map') uses.discard('ol.renderer.Map')