Make code prettier
This updates ESLint and our shared eslint-config-openlayers to use Prettier. Most formatting changes were automatically applied with this:
npm run lint -- --fix
A few manual changes were required:
* In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import.
* In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason. While editing this, I reworked `ExampleBuilder` to be a class.
* In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.
This commit is contained in:
@@ -1,28 +1,29 @@
|
||||
import * as render from '../../../../../src/ol/render/canvas.js';
|
||||
|
||||
|
||||
describe('ol.render.canvas', function() {
|
||||
|
||||
describe('ol.render.canvas', function () {
|
||||
const font = document.createElement('link');
|
||||
font.href = 'https://fonts.googleapis.com/css?family=Abel&text=wmytzilWMYTZIL%40%23%2F%26%3F%24%2510';
|
||||
font.href =
|
||||
'https://fonts.googleapis.com/css?family=Abel&text=wmytzilWMYTZIL%40%23%2F%26%3F%24%2510';
|
||||
font.rel = 'stylesheet';
|
||||
const head = document.getElementsByTagName('head')[0];
|
||||
|
||||
describe('ol.render.canvas.registerFont()', function() {
|
||||
|
||||
beforeEach(function() {
|
||||
describe('ol.render.canvas.registerFont()', function () {
|
||||
beforeEach(function () {
|
||||
render.checkedFonts.values_ = {};
|
||||
render.measureTextHeight('12px sans-serif');
|
||||
});
|
||||
|
||||
const retries = 100;
|
||||
|
||||
it('does not trigger redraw and clear measurements for unavailable fonts', function(done) {
|
||||
it('does not trigger redraw and clear measurements for unavailable fonts', function (done) {
|
||||
this.timeout(4000);
|
||||
const spy = sinon.spy();
|
||||
render.checkedFonts.addEventListener('propertychange', spy);
|
||||
const interval = setInterval(function() {
|
||||
if (render.checkedFonts.get('normal\nnormal\nfoo') == retries && render.checkedFonts.get('normal\nnormal\nsans-serif') == retries) {
|
||||
const interval = setInterval(function () {
|
||||
if (
|
||||
render.checkedFonts.get('normal\nnormal\nfoo') == retries &&
|
||||
render.checkedFonts.get('normal\nnormal\nsans-serif') == retries
|
||||
) {
|
||||
clearInterval(interval);
|
||||
render.checkedFonts.removeEventListener('propertychange', spy);
|
||||
expect(spy.callCount).to.be(0);
|
||||
@@ -33,10 +34,10 @@ describe('ol.render.canvas', function() {
|
||||
render.registerFont('12px foo,sans-serif');
|
||||
});
|
||||
|
||||
it('does not trigger redraw and clear measurements for available fonts', function(done) {
|
||||
it('does not trigger redraw and clear measurements for available fonts', function (done) {
|
||||
const spy = sinon.spy();
|
||||
render.checkedFonts.addEventListener('propertychange', spy);
|
||||
const interval = setInterval(function() {
|
||||
const interval = setInterval(function () {
|
||||
if (render.checkedFonts.get('normal\nnormal\nsans-serif') == retries) {
|
||||
clearInterval(interval);
|
||||
render.checkedFonts.removeEventListener('propertychange', spy);
|
||||
@@ -48,10 +49,10 @@ describe('ol.render.canvas', function() {
|
||||
render.registerFont('12px sans-serif');
|
||||
});
|
||||
|
||||
it('does not trigger redraw and clear measurements for the \'monospace\' font', function(done) {
|
||||
it("does not trigger redraw and clear measurements for the 'monospace' font", function (done) {
|
||||
const spy = sinon.spy();
|
||||
render.checkedFonts.addEventListener('propertychange', spy);
|
||||
const interval = setInterval(function() {
|
||||
const interval = setInterval(function () {
|
||||
if (render.checkedFonts.get('normal\nnormal\nmonospace') == retries) {
|
||||
clearInterval(interval);
|
||||
render.checkedFonts.removeEventListener('propertychange', spy);
|
||||
@@ -63,33 +64,41 @@ describe('ol.render.canvas', function() {
|
||||
render.registerFont('12px monospace');
|
||||
});
|
||||
|
||||
it('triggers redraw and clear measurements for fonts that become available', function(done) {
|
||||
it('triggers redraw and clear measurements for fonts that become available', function (done) {
|
||||
head.appendChild(font);
|
||||
render.checkedFonts.addEventListener('propertychange', function onPropertyChange(e) {
|
||||
render.checkedFonts.removeEventListener('propertychange', onPropertyChange);
|
||||
expect(e.key).to.be('normal\nnormal\nAbel');
|
||||
expect(render.textHeights).to.eql({});
|
||||
done();
|
||||
});
|
||||
render.checkedFonts.addEventListener(
|
||||
'propertychange',
|
||||
function onPropertyChange(e) {
|
||||
render.checkedFonts.removeEventListener(
|
||||
'propertychange',
|
||||
onPropertyChange
|
||||
);
|
||||
expect(e.key).to.be('normal\nnormal\nAbel');
|
||||
expect(render.textHeights).to.eql({});
|
||||
done();
|
||||
}
|
||||
);
|
||||
render.registerFont('12px Abel');
|
||||
});
|
||||
|
||||
});
|
||||
|
||||
describe('measureTextHeight', function() {
|
||||
it('respects line-height', function() {
|
||||
describe('measureTextHeight', function () {
|
||||
it('respects line-height', function () {
|
||||
const height = render.measureTextHeight('12px/1.2 sans-serif');
|
||||
expect(render.measureTextHeight('12px/2.4 sans-serif')).to.be.greaterThan(height);
|
||||
expect(render.measureTextHeight('12px/0.1 sans-serif')).to.be.lessThan(height);
|
||||
expect(render.measureTextHeight('12px/2.4 sans-serif')).to.be.greaterThan(
|
||||
height
|
||||
);
|
||||
expect(render.measureTextHeight('12px/0.1 sans-serif')).to.be.lessThan(
|
||||
height
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
describe('rotateAtOffset', function() {
|
||||
it('rotates a canvas at an offset point', function() {
|
||||
describe('rotateAtOffset', function () {
|
||||
it('rotates a canvas at an offset point', function () {
|
||||
const context = {
|
||||
translate: sinon.spy(),
|
||||
rotate: sinon.spy()
|
||||
rotate: sinon.spy(),
|
||||
};
|
||||
render.rotateAtOffset(context, Math.PI, 10, 10);
|
||||
expect(context.translate.callCount).to.be(2);
|
||||
@@ -100,14 +109,14 @@ describe('ol.render.canvas', function() {
|
||||
});
|
||||
});
|
||||
|
||||
describe('drawImageOrLabel', function() {
|
||||
it('draws the image with correct parameters', function() {
|
||||
describe('drawImageOrLabel', function () {
|
||||
it('draws the image with correct parameters', function () {
|
||||
const layerContext = {
|
||||
save: sinon.spy(),
|
||||
setTransform: sinon.spy(),
|
||||
drawImage: sinon.spy(),
|
||||
restore: sinon.spy(),
|
||||
globalAlpha: 1
|
||||
globalAlpha: 1,
|
||||
};
|
||||
const transform = [1, 0, 0, 1, 0, 0];
|
||||
const opacity = 0.5;
|
||||
@@ -118,16 +127,26 @@ describe('ol.render.canvas', function() {
|
||||
const h = 1;
|
||||
const scale = 1;
|
||||
|
||||
render.drawImageOrLabel(layerContext, transform.slice(), opacity, image,
|
||||
x, y, w, h, x, y, scale);
|
||||
render.drawImageOrLabel(
|
||||
layerContext,
|
||||
transform.slice(),
|
||||
opacity,
|
||||
image,
|
||||
x,
|
||||
y,
|
||||
w,
|
||||
h,
|
||||
x,
|
||||
y,
|
||||
scale
|
||||
);
|
||||
|
||||
expect(layerContext.save.callCount).to.be(1);
|
||||
expect(layerContext.setTransform.callCount).to.be(1);
|
||||
expect(layerContext.setTransform.firstCall.args).to.eql(transform);
|
||||
expect(layerContext.drawImage.callCount).to.be(1);
|
||||
expect(layerContext.globalAlpha).to.be(.5);
|
||||
expect(layerContext.globalAlpha).to.be(0.5);
|
||||
expect(layerContext.restore.callCount).to.be(1);
|
||||
});
|
||||
});
|
||||
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user