Move setup step to #startWriting method.

This commit is contained in:
Young Hahn
2012-02-24 17:15:50 -05:00
parent 0b85f40edd
commit cca4271aa3
2 changed files with 19 additions and 16 deletions
+14 -11
View File
@@ -55,9 +55,6 @@ function MBTiles(uri, callback) {
this._batchSize = +uri.query.batch; this._batchSize = +uri.query.batch;
Step(function() { Step(function() {
mbtiles._db = new sqlite3.Database(mbtiles.filename, this); mbtiles._db = new sqlite3.Database(mbtiles.filename, this);
}, function(err) {
if (err) throw err;
mbtiles._setup(this);
}, function(err) { }, function(err) {
if (err) throw err; if (err) throw err;
fs.stat(mbtiles.filename, this); fs.stat(mbtiles.filename, this);
@@ -389,18 +386,24 @@ MBTiles.prototype.startWriting = function(callback) {
if (typeof callback !== 'function') throw new Error('Callback needed'); if (typeof callback !== 'function') throw new Error('Callback needed');
if (!this.open) return callback(new Error('MBTiles not yet loaded')); if (!this.open) return callback(new Error('MBTiles not yet loaded'));
var mbtiles = this;
Step(function() {
mbtiles._setup(this);
}, function(err) {
if (err) throw err;
// Sets the synchronous flag to OFF for (much) faster inserts. // Sets the synchronous flag to OFF for (much) faster inserts.
// See http://www.sqlite3.org/pragma.html#pragma_synchronous // See http://www.sqlite3.org/pragma.html#pragma_synchronous
if (!mbtiles._isWritable) {
var mbtiles = this; mbtiles._isWritable = 1;
if (!this._isWritable) { mbtiles._clearCaches();
this._isWritable = 1; mbtiles._db.run('PRAGMA synchronous=OFF', this);
this._clearCaches();
this._db.run('PRAGMA synchronous=OFF', callback);
} else { } else {
this._isWritable++; mbtiles._isWritable++;
return callback(null); this();
} }
}, function(err) {
return callback(err);
});
}; };
MBTiles.prototype._clearCaches = function() { MBTiles.prototype._clearCaches = function() {
+2 -2
View File
@@ -61,7 +61,7 @@ exports['get/put metadata from empty file'] = function(beforeExit) {
assert.deepEqual({ assert.deepEqual({
basename: "empty.mbtiles", basename: "empty.mbtiles",
filesize: 16384, filesize: 0,
id: "empty", id: "empty",
scheme: "tms" scheme: "tms"
}, data); }, data);
@@ -89,7 +89,7 @@ exports['get/put metadata from empty file'] = function(beforeExit) {
assert.deepEqual({ assert.deepEqual({
basename: "empty.mbtiles", basename: "empty.mbtiles",
filesize: 16384, filesize: 0,
id: "empty", id: "empty",
scheme: "tms", scheme: "tms",
version: "1.0.0" version: "1.0.0"