mirror of
https://github.com/maputnik/editor.git
synced 2026-09-14 16:27:27 +00:00
undef_26
a3e9c91ce0
#1351 made `styleStore` initialization asynchronous in `componentDidMount`. `setStyle` currently treats `toolbar:link` appearing as the signal that loading is complete, but if the style network request (`empty-style.json` from jsdelivr) takes over ~1s, the `toolbar:link` can appear while `styleStore` is still null (because the request has not finished). Subsequent `saveStyle` calls in tests then silently do nothing, causing test failures (3 in #2157, and often 20+ on my machine). Changes are: 1. Mock the default empty style to avoid slow network E2E failures. 2. Also cap Playwright workers at 4 to avoid overloading Chromium on high-core machines. Fixes #2158. ## Launch Checklist <!-- Thanks for the PR! Feel free to add or remove items from the checklist. --> - [x] Briefly describe the changes in this PR. - [x] Link to related issues. - [ ] ~~Include before/after visuals or gifs if this PR includes visual changes.~~ - [ ] ~~Write tests for all new functionality.~~ - [ ] ~~Add an entry to `CHANGELOG.md` under the `## main` section.~~ (only minor test infra fix) Co-authored-by: liuly <me@liuly.moe> Co-authored-by: Harel M <harel.mazor@gmail.com>
52 lines
1.6 KiB
TypeScript
52 lines
1.6 KiB
TypeScript
import { cpus } from "node:os";
|
|
import { defineConfig, devices } from "@playwright/test";
|
|
|
|
const isCI = !!process.env.CI;
|
|
// Playwright defaults to CPU / 2 workers,
|
|
// capping the number of workers to 4 to avoid overloading browsers.
|
|
const workers = Math.min(4, Math.max(1, Math.floor(cpus().length / 2)));
|
|
// When the app is already served elsewhere (e.g. the docker e2e job) set
|
|
// E2E_NO_WEBSERVER=1 so Playwright does not start its own dev server.
|
|
const useExternalServer = !!process.env.E2E_NO_WEBSERVER;
|
|
const baseURL = process.env.E2E_BASE_URL ?? "http://localhost:8888/";
|
|
|
|
export default defineConfig({
|
|
testDir: "./e2e",
|
|
testMatch: "**/*.spec.ts",
|
|
globalSetup: "./e2e/utils/e2e-setup.ts",
|
|
globalTeardown: "./e2e/utils/e2e-teardown.ts",
|
|
fullyParallel: true,
|
|
forbidOnly: isCI,
|
|
workers,
|
|
retries: isCI ? 2 : 0,
|
|
reporter: isCI ? [["list"], ["html", { open: "never" }]] : "list",
|
|
use: {
|
|
baseURL,
|
|
trace: "on-first-retry",
|
|
},
|
|
projects: [
|
|
{
|
|
name: "chromium",
|
|
use: {
|
|
...devices["Desktop Chrome"],
|
|
launchOptions: {
|
|
// Allow WebGL (maplibre) to fall back to software rendering in headless.
|
|
args: [
|
|
"--disable-gpu",
|
|
"--enable-features=AllowSwiftShaderFallback,AllowSoftwareGLFallbackDueToCrashes",
|
|
"--enable-unsafe-swiftshader",
|
|
],
|
|
},
|
|
},
|
|
},
|
|
],
|
|
webServer: useExternalServer
|
|
? undefined
|
|
: {
|
|
command: "npm run start",
|
|
url: "http://localhost:8888/maputnik/",
|
|
reuseExistingServer: !isCI,
|
|
timeout: 120000,
|
|
},
|
|
});
|