Keeps the repo clean, same as several other of our repos
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Going from e.g. MapTiler to OpenLayers and back will lose the maptlier
key.
This code finds the urls in the style that has "{key}" and insert the
correct API keys
Fixes the error reported here, cc @nyurik
- Fixes
https://github.com/maplibre/maputnik/issues/874#issuecomment-2605896666
Related to:
- https://github.com/maplibre/maputnik/issues/869
## Launch Checklist
<!-- Thanks for the PR! Feel free to add or remove items from the
checklist. -->
- [ ] Briefly describe the changes in this PR.
- [ ] Link to related issues.
- [ ] Include before/after visuals or gifs if this PR includes visual
changes.
- [ ] Write tests for all new functionality.
- [ ] Add an entry to `CHANGELOG.md` under the `## main` section.
It's apparently forced now to use the eslint.config.js instead of
.eslintrc
It got more strict with requiring the underscore on unused vars like
`catch(_err)` , but that was all
Closes#1012Closes#995Closes#992
## Launch Checklist
<!-- Thanks for the PR! Feel free to add or remove items from the
checklist. -->
- [ ] Briefly describe the changes in this PR.
- [ ] Link to related issues.
- [ ] Include before/after visuals or gifs if this PR includes visual
changes.
- [ ] Write tests for all new functionality.
- [ ] Add an entry to `CHANGELOG.md` under the `## main` section.
Closes#996
## Launch Checklist
<!-- Thanks for the PR! Feel free to add or remove items from the
checklist. -->
- [ ] Briefly describe the changes in this PR.
- [ ] Link to related issues.
- [ ] Include before/after visuals or gifs if this PR includes visual
changes.
- [ ] Write tests for all new functionality.
- [ ] Add an entry to `CHANGELOG.md` under the `## main` section.
Bumps
[eslint-plugin-react-refresh](https://github.com/ArnaudBarre/eslint-plugin-react-refresh)
from 0.4.6 to 0.4.18.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/ArnaudBarre/eslint-plugin-react-refresh/releases">eslint-plugin-react-refresh's
releases</a>.</em></p>
<blockquote>
<h2>v0.4.18</h2>
<p>ESM/CJS interop is the worse that happened to this ecosystem, this is
all I have to say.</p>
<h2>v0.4.17</h2>
<ul>
<li>Fix detection of local components to not generate warning on for
variable inside JSX files that follow React component naming (fixes <a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/75">#75</a>)</li>
<li>Update types to not require extra unnecessary <code>.default</code>
property access under TS node16 module resolution (fixes <a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/70">#70</a>)</li>
</ul>
<h2>v0.4.16</h2>
<p>Fix CJS/ESM interop issue. Sorry everyone for the trouble.</p>
<h2>v0.4.15</h2>
<h3>Add support for custom HOCs (<a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/60">#60</a>)</h3>
<p>By default, the rule only knows that <code>memo</code> &
<code>forwardRef</code> function calls with return a React component.
With this option, you can also allow extra function names like Mobx
observer to make this code valid:</p>
<pre lang="tsx"><code>const Foo = () => <></>;
export default observer(Foo);
</code></pre>
<pre lang="json"><code>{
"react-refresh/only-export-components": [
"error",
{ "customHOCs": ["observer"] }
]
}
</code></pre>
<p>Thanks <a
href="https://github.com/HorusGoul"><code>@HorusGoul</code></a>!</p>
<h3>Add recommended config and simple types (<a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/67">#67</a>)</h3>
<p>You can now add the recommended config to your ESLint config like
this:</p>
<pre lang="js"><code>import reactRefresh from
"eslint-plugin-react-refresh";
<p>export default [
/* Main config */
reactRefresh.configs.recommended, // Or reactRefresh.configs.vite for
Vite users
];
</code></pre></p>
<p>To follow ESLint recommandations, the rule is added with the
<code>error</code> severity.</p>
<p>Some simple types ensure that people typecheking their config won't
need <code>@ts-expect-error</code> anymore.</p>
<h3>Bump ESLint peer dependency to 8.40</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/main/CHANGELOG.md">eslint-plugin-react-refresh's
changelog</a>.</em></p>
<blockquote>
<h2>0.4.18</h2>
<p>ESM/CJS interop is the worth that happend to this ecosystem, this is
all I have to say.</p>
<h2>0.4.17</h2>
<ul>
<li>Fix detection of local components to not generate warning on for
variable inside JSX files that follow React component naming (fixes <a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/75">#75</a>)</li>
<li>Update types to not require extra unnecessary <code>.default</code>
property access under TS node16 module resolution (fixes <a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/70">#70</a>)</li>
</ul>
<h2>0.4.16</h2>
<p>Fix CJS/ESM interop issue. Sorry everyone for the trouble.</p>
<h2>0.4.15</h2>
<h3>Add support for custom HOCs (<a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/60">#60</a>)</h3>
<p>By default, the rule only knows that <code>memo</code> &
<code>forwardRef</code> function calls with return a React component.
With this option, you can also allow extra function names like Mobx
observer to make this code valid:</p>
<pre lang="tsx"><code>const Foo = () => <></>;
export default observer(Foo);
</code></pre>
<pre lang="json"><code>{
"react-refresh/only-export-components": [
"error",
{ "customHOCs": ["observer"] }
]
}
</code></pre>
<p>Thanks <a
href="https://github.com/HorusGoul"><code>@HorusGoul</code></a>!</p>
<h3>Add recommended config and simple types (<a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/67">#67</a>)</h3>
<p>You can now add the recommended config to your ESLint config like
this:</p>
<pre lang="js"><code>import reactRefresh from
"eslint-plugin-react-refresh";
<p>export default [
/* Main config */
reactRefresh.configs.recommended, // Or reactRefresh.configs.vite for
Vite users
];
</code></pre></p>
<p>To follow ESLint recommandations, the rule is added with the
<code>error</code> severity.</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="3d6251de43"><code>3d6251d</code></a>
Fix types [publish]</li>
<li><a
href="47f25f07d9"><code>47f25f0</code></a>
Update types to not require extra unnecessary <code>.default</code>
property access unde...</li>
<li><a
href="639e7724f4"><code>639e772</code></a>
Fix detection of local components to not generate warning on for
variable ins...</li>
<li><a
href="d939cc4bd4"><code>d939cc4</code></a>
Fix exports [publish]</li>
<li><a
href="7d1709b065"><code>7d1709b</code></a>
0.4.15 [publish]</li>
<li><a
href="ec747c2a25"><code>ec747c2</code></a>
Add configs and simple types (<a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/67">#67</a>)</li>
<li><a
href="359ae21a40"><code>359ae21</code></a>
Bump ESLint peer dependency (fixes <a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/56">#56</a>)</li>
<li><a
href="86bddb3b9a"><code>86bddb3</code></a>
Add changelog entry & simplify legacy name based only check</li>
<li><a
href="478e7788bd"><code>478e778</code></a>
Add basic support for custom HOCs (<a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/60">#60</a>)</li>
<li><a
href="94c9d7d98c"><code>94c9d7d</code></a>
docs: switch suggested severity from 'warn' to 'error' (<a
href="https://redirect.github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/66">#66</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.6...v0.4.18">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Harel M <harel.mazor@gmail.com>
## Launch Checklist
<!-- Thanks for the PR! Feel free to add or remove items from the
checklist. -->
- [x] Briefly describe the changes in this PR.
- [x] Link to related issues.
- [x] Include before/after visuals or gifs if this PR includes visual
changes.
- [ ] Write tests for all new functionality.
- [x] Add an entry to `CHANGELOG.md` under the `## main` section.
## Description
`showOpenFilePicker` and `showSaveFilePicker` are undefined on Firefox.
With this pr, Maputnik uses the old behavior as a fallback. It keeps the
naming "open" and "save" instead of "upload" and "download" to underline
that the style stays within the browser and no actual upload happens.
@zstadler Could you give it a try, please?
## Related Issue
- fixes https://github.com/maplibre/maputnik/issues/966
## Visual Changes
The "Save as" button gets hidden if `showSaveFilePicker` is not
available since it would have no use.
<table>
<tr>
<td>
Chrome
</td>
<td>
Firefox
</td>
</tr>
<tr>
<td>
<img
src="https://github.com/user-attachments/assets/cdc2cd4d-1c09-4dec-8c94-f8b0dd0c5b8e"
/>
</td>
<td>
<img
src="https://github.com/user-attachments/assets/0763ef63-6501-4cc1-977b-94753c3008ae"
/>
</td>
</tr>
</table>
## Launch Checklist
<!-- Thanks for the PR! Feel free to add or remove items from the
checklist. -->
- [x] Briefly describe the changes in this PR.
- [x] Link to related issues.
- [x] Include before/after visuals or gifs if this PR includes visual
changes.
- [ ] Write tests for all new functionality.
- [x] Add an entry to `CHANGELOG.md` under the `## main` section.
## Changes
- This pull request makes use of the FileSystemFileHandle API to modify
a local file. No need to download it - just click save.
- I don't know how to cover this functionality by tests so I need
directions in case test coverage is required.
- The pull request adds
[@types/wicg-file-system-access](https://www.npmjs.com/package/@types/wicg-file-system-access)
as a new dev dependency which I am not really pleased about but can't
think of a way around it.
## Known Limitations
- The used File API is only available in when accessed from https or on
localhost.
- There is no visual indicator that the file has been saved. Previously
the browser showed it as a new download.
## Issue
- https://github.com/maplibre/maputnik/issues/964
## Screenshots
### Menu
<img
src="https://github.com/user-attachments/assets/dfcfc5c2-0019-4857-ba26-224b5598fc11"
/>
### Open modal
<img
src="https://github.com/user-attachments/assets/4e1293e8-16b6-4b86-925b-3bebb49d8ca6"
height="200px" />
### Save modal
<img
src="https://github.com/user-attachments/assets/4f10e2c0-2dd3-4726-a613-30e0406619b0"
height="200px" />
---------
Co-authored-by: Harel M <harel.mazor@gmail.com>
## Launch Checklist
- [x] Briefly describe the changes in this PR.
* When adding a new Raster or Raster-dem tile source, use `.png` as the
hint for the tile URL hint prompt.
* Currently, the user is prompted for a Vector tile source (e.g.,
`.pbf`)
* If a new Mapnik user already has their XYZ raster Tile URL, then they
may already know how to modify this text field.
* This change may be useful for new users and is intended for them.
* `.png` is a start. It could be `.webp` or `.jpg`, or `.jpg`, or in the
case of Esri there is no extension for the images.
* See [RobLabs.com/xyz](https://RobLabs.com/xyz) for sample XYZ raster
tile URLs
---
- [x] Include before/after visuals or gifs if this PR includes visual
changes.
* Steps to reproduce
* See [RobLabs.com/maputnik](https://roblabs.com/maputnik) for a working
version of this fix for Maputnik
* On top menu bar: *Data Sources* > In the *Add New Source* section >
Change *Source Type* to "Raster (Tile URLs)"
* There you will see prompt hint for a raster Tile instead of vector
tile `.pbf`.
* See the release notes for the National Park Service prototype release
for [Maputnik for National Park Service Park
Tiles](https://github.com/roblabs/maputnik/releases/tag/v2.1.1-nationalparkservice)
for more screen shots.
#### Before
`.pbf` may be confusing for those adding a Raster
#### After
---
- [x] Write tests for all new functionality.
* See screen shots for functionality
- ~~[] Add an entry to `CHANGELOG.md` under the `## main` section.~~
*Not really a feature, so I will leave this out*
- [ ] ~~Link to related issues.~~
## Launch Checklist
<!-- Thanks for the PR! Feel free to add or remove items from the
checklist. -->
- [x] Briefly describe the changes in this PR.
- [ ] Link to related issues.
- [x] Include before/after visuals or gifs if this PR includes visual
changes.
- [ ] Write tests for all new functionality.
- [x] Add an entry to `CHANGELOG.md` under the `## main` section.
## Launch Checklist
This adds information about how to translate Maputnik and how to get in
touch with people who have translated in the past.
@keichan34, @jieme, @lhapaipai - I need your approval for this so that
people in the future will know to contact you in case text is being
added and they need help translating it.
CC: @ianthetechie
I've also changed the word "Language" in the upper part of the screen so
that it won't be translated in case you accidentally switch language,
and you need to switch back.
I've also fixed some RTL issues in the CSS and updated the maplibre
components labels when the language changes.
This is a rough start on adding react-i18next. I'll be working on adding
more translatable strings and translations in the coming days. I'm going
to need to wrap class components in HOCs, so let me know if there's
something I should be fixing before doing that. I'm thinking now to keep
the exported class names exactly the same, and rename the existing
classes by prefixing an `I` (for internal). For example:
```
export default class AppToolbar ...
```
becomes
```
class IAppToolbar ...
const AppToolbar = withTranslation()(IAppToolbar);
export default AppToolbar;
```
I'll be able to contribute Japanese strings (I've talked to a couple
people on my team and they'll be happy to help as well), so that's the
language I decided to go with in this PR.
Closes#746
---------
Co-authored-by: Ko Nagase <nagase@georepublic.co.jp>
Co-authored-by: Harel M <harel.mazor@gmail.com>
Current label, "Feature ID", creates a little bit of confusion. It's not
clear that this label isn't really part of the feature properties.
For example, when we want to filter by feature id, we need to use `$id`
```
[==, "$id," 123]
```
This PR aims at updating some packages.
I'll keep this in draft until I'll be more happy with the results.
Current setup seems to work, I'll let the CI run and see how bad this
is.
Packages that needs to be updated/replaces:
- [x] ~autocompete - The only warning left in the console is related to
the autocomplete, which probably needs to be updated since it's a
package that wasn't updated in the last 6 years.~ #611
- [x] ~Codemirror is also something that will need an update, but it
looks too complicated at this point in time, so let's see how this
goes.~ #891
- [ ] react-color
- [x] ~react-aria-menubutton~ #846
- [ ] Others?
Most of the changes here are related to types, which is good.
Fixes#871
- #871
In case of same sources, calling the render method when the map style
changes, but not right away to let the map load the sources should fix
the issue.
Fixes#868
- #868
It solves all the block within blocks and all kind of controls that are
not required which creates gaps.
I use a simple table, so the width is dynamic but it is always aligned
for all the properties and the features.
Vary basic stuff.
There's still the layer popup, which I'm not sure I know what it is and
might need to be fixed as well.
CC: @zstadler
Fixes#870
- #870
This regression bug was introduced as part of the refactoring of
typescript.
Here:
- #848
I've added tests to cover the scenario so that it won't happen again,
hopefully.
Fixes#861
This should hopefully address the last item in the below issue of the
missing logo.
I tested it locally and it seems to be working as expected, I hope this
will be the case once deployed.
- #861
1. Changed references to point to this new repo
2. Fixed docker image publishing to point to ghcr.io.
3. Remove survey link - the survey is closed and there's no point in
keeping it.
4. Remove storybook - Basically a storybook is the ability to look at
components and see how they look and interact with them.
It's a powerful tool for developing component library with "live"
documentation.
But it's an overkill for this project and I would like to reduce
maintenance costs.
Currently all the "stories" are in javascript and not in typescript and
it feels like a waste of time to try and maintain it, along with
updating the storybook library itself and everything around it.
This PR aims at updating MapLibre dependencies.
The main goal of this update is to allow adding terrain specification to
the editor.
This requires version 4 of maplibre so currently it will use the
pre-release.
Recover commented out tests,
Improve usage of helper in driver,
Added data-wd-key for test to use instead of classes
Moved all non tsx file to a single folder (lib) instead of lib and utils
---------
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
Adds lint to CI and fixes errors.
I'm not sure I'm fully proud of all the solutions there.
But there's no lint issues and the lint is being checked as part of the
CI.
---------
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
In this PR I have changed some of the jsx files to tsx file.
I'm starting off with the "leafs" so that migration of the rest will be
easier, hopefully.
What I'm basically doing is taking a jsx file, copy paste it into:
https://mskelton.dev/ratchet
And after that I'm fixing the types as needed.
It's not a very long process.
Hopefully more PRs will follow and this will be over soon.
I don't plan to migrate the storybook as I generally don't understand
why is it useful, I'll open an issue to see if anyone thinks
differently.
This completes the migration to typescript of all the non react
components code.
The only changes introduced besides types are the type checks using
`"something" in object` which narrows down types in typescript.
This migrates some utilities classes from javascript to typescript.
Nothing special about the migration, mainly added types and made sure
the code adheres to the strict mode.
I have picked some small files so git doesn't think they are the same
since they are "very different".
I hope that in later PRs, when migrating lager files this won't be an
issues.
This is basically the content of #841 with the code review changes and
relevant fixes to tests/driver code to pass the tests.
CC: @ShellyDCMS
After this we should lint the project and add the lint to the CI to make
sure it doesn't break.
---------
Co-authored-by: ShellyDCMS <60476837+ShellyDCMS@users.noreply.github.com>
Co-authored-by: shelly_goldblit <shelly_goldblit@dell.com>
Resolves#803
This is an initial commit to allow migrating to typescript bit by bit.
It introduces vite.
It removes all the webpack configuration (which I have no clue what all
the profiling are needed for, and couldn't find anything in the readme).
It also changes a single file from javascript to typescript:
`urlopen.js` -> `urlopen.ts`
Which was done manually, later on I'll see if I can automate most of the
migration.
For now, everything seems to work as expected.
I also upgrades storybook to use vite and renames the stories to jsx (I
honestly don't know why this complexity is needed here, but I'll keep it
for now).
cc: @damianstasik
* Added additional checkbox to set the cluster attribute when adding a GeoJson source
* Fixed default source function in the 'geojson_json' case
---------
Co-authored-by: shimon <ruisuhsh100@gmail.com>
