test: adopt Playwright test()/test.describe() naming in e2e specs

Mechanical rename of it() -> test() and describe() -> test.describe() so the
subsequent Playwright migration diff only touches test bodies, not the
suite/case wrappers.
This commit is contained in:
HarelM
2026-07-08 12:42:13 +03:00
parent 8af1cfd5f8
commit f7b48139a4
9 changed files with 174 additions and 174 deletions
+54 -54
View File
@@ -1,34 +1,34 @@
import { MaputnikDriver } from "./maputnik-driver";
import tokens from "../../src/config/tokens.json" with {type: "json"};
describe("modals", () => {
test.describe("modals", () => {
const { beforeAndAfter, when, get, given, then } = new MaputnikDriver();
beforeAndAfter();
beforeEach(() => {
when.setStyle("");
});
describe("open", () => {
test.describe("open", () => {
beforeEach(() => {
when.click("nav:open");
});
it("close", () => {
test("close", () => {
when.modal.close("modal:open");
then(get.elementByTestId("modal:open")).shouldNotExist();
});
it("upload", () => {
test("upload", () => {
when.chooseExampleFile();
then(get.fixture("example-style.json")).shouldEqualToStoredStyle();
});
it("upload via drag and drop", () => {
test("upload via drag and drop", () => {
when.dropExampleFile();
then(get.fixture("example-style.json")).shouldEqualToStoredStyle();
});
describe("when click open url", () => {
test.describe("when click open url", () => {
beforeEach(() => {
const styleFileUrl = get.exampleFileUrl();
@@ -36,14 +36,14 @@ describe("modals", () => {
when.click("modal:open.url.button");
when.wait(200);
});
it("load from url", () => {
test("load from url", () => {
then(get.responseBody("example-style.json")).shouldEqualToStoredStyle();
});
});
});
describe("shortcuts", () => {
it("open/close", () => {
test.describe("shortcuts", () => {
test("open/close", () => {
when.setStyle("");
when.typeKeys("?");
when.modal.close("modal:shortcuts");
@@ -51,30 +51,30 @@ describe("modals", () => {
});
});
describe("export", () => {
test.describe("export", () => {
beforeEach(() => {
when.click("nav:export");
});
it("close", () => {
test("close", () => {
when.modal.close("modal:export");
then(get.elementByTestId("modal:export")).shouldNotExist();
});
// TODO: Work out how to download a file and check the contents
it("download");
test("download");
});
describe("sources", () => {
test.describe("sources", () => {
beforeEach(() => {
when.setStyle("layer");
when.click("nav:sources");
});
it("active sources");
it("public source");
test("active sources");
test("public source");
it("add new source", () => {
test("add new source", () => {
const sourceId = "n1z2v3r";
when.setValue("modal:sources.add.source_id", sourceId);
when.select("modal:sources.add.source_type", "tile_vector");
@@ -88,7 +88,7 @@ describe("modals", () => {
});
});
it("add new pmtiles source", () => {
test("add new pmtiles source", () => {
const sourceId = "pmtilestest";
when.setValue("modal:sources.add.source_id", sourceId);
when.select("modal:sources.add.source_type", "pmtiles_vector");
@@ -106,7 +106,7 @@ describe("modals", () => {
});
});
it("add new raster source", () => {
test("add new raster source", () => {
const sourceId = "rastertest";
when.setValue("modal:sources.add.source_id", sourceId);
when.select("modal:sources.add.source_type", "tile_raster");
@@ -122,59 +122,59 @@ describe("modals", () => {
});
});
describe("inspect", () => {
it("toggle", () => {
test.describe("inspect", () => {
test("toggle", () => {
// There is no assertion in this test
when.setStyle("geojson");
when.select("maputnik-select", "inspect");
});
});
describe("style settings", () => {
test.describe("style settings", () => {
beforeEach(() => {
when.click("nav:settings");
});
describe("when click name filed spec information", () => {
test.describe("when click name filed spec information", () => {
beforeEach(() => {
when.click("field-doc-button-Name");
});
it("should show the spec information", () => {
test("should show the spec information", () => {
then(get.elementsText("spec-field-doc")).shouldInclude(
"name for the style"
);
});
});
describe("when set name and click owner", () => {
test.describe("when set name and click owner", () => {
beforeEach(() => {
when.setValue("modal:settings.name", "foobar");
when.click("modal:settings.owner");
when.wait(200);
});
it("show name specifications", () => {
test("show name specifications", () => {
then(get.styleFromLocalStorage()).shouldDeepNestedInclude({
name: "foobar",
});
});
});
describe("when set owner and click name", () => {
test.describe("when set owner and click name", () => {
beforeEach(() => {
when.setValue("modal:settings.owner", "foobar");
when.click("modal:settings.name");
when.wait(200);
});
it("should update owner in local storage", () => {
test("should update owner in local storage", () => {
then(get.styleFromLocalStorage()).shouldDeepNestedInclude({
owner: "foobar",
});
});
});
it("sprite url", () => {
test("sprite url", () => {
when.setTextInJsonEditor("\"http://example.com\"");
when.click("modal:settings.name");
then(get.styleFromLocalStorage()).shouldDeepNestedInclude({
@@ -182,7 +182,7 @@ describe("modals", () => {
});
});
it("sprite object", () => {
test("sprite object", () => {
when.setTextInJsonEditor(JSON.stringify([{ id: "1", url: "2" }]));
when.click("modal:settings.name");
@@ -191,7 +191,7 @@ describe("modals", () => {
});
});
it("glyphs url", () => {
test("glyphs url", () => {
const glyphsUrl = "http://example.com/{fontstack}/{range}.pbf";
when.setValue("modal:settings.glyphs", glyphsUrl);
when.click("modal:settings.name");
@@ -200,7 +200,7 @@ describe("modals", () => {
});
});
it("maptiler access token", () => {
test("maptiler access token", () => {
const apiKey = "testing123";
when.setValue(
"modal:settings.maputnik:openmaptiles_access_token",
@@ -214,7 +214,7 @@ describe("modals", () => {
});
});
it("thunderforest access token", () => {
test("thunderforest access token", () => {
const apiKey = "testing123";
when.setValue(
"modal:settings.maputnik:thunderforest_access_token",
@@ -226,7 +226,7 @@ describe("modals", () => {
).shouldInclude({ "maputnik:thunderforest_access_token": apiKey });
});
it("stadia access token", () => {
test("stadia access token", () => {
const apiKey = "testing123";
when.setValue(
"modal:settings.maputnik:stadia_access_token",
@@ -238,7 +238,7 @@ describe("modals", () => {
).shouldInclude({ "maputnik:stadia_access_token": apiKey });
});
it("locationiq access token", () => {
test("locationiq access token", () => {
const apiKey = "testing123";
when.setValue(
"modal:settings.maputnik:locationiq_access_token",
@@ -250,14 +250,14 @@ describe("modals", () => {
).shouldInclude({ "maputnik:locationiq_access_token": apiKey });
});
it("style projection mercator", () => {
test("style projection mercator", () => {
when.select("modal:settings.projection", "mercator");
then(
get.styleFromLocalStorage().then((style) => style.projection)
).shouldInclude({ type: "mercator" });
});
it("style projection globe", () => {
test("style projection globe", () => {
when.select("modal:settings.projection", "globe");
then(
get.styleFromLocalStorage().then((style) => style.projection)
@@ -265,7 +265,7 @@ describe("modals", () => {
});
it("style projection vertical-perspective", () => {
test("style projection vertical-perspective", () => {
when.select("modal:settings.projection", "vertical-perspective");
then(
get.styleFromLocalStorage().then((style) => style.projection)
@@ -273,7 +273,7 @@ describe("modals", () => {
});
it("style renderer", () => {
test("style renderer", () => {
cy.on("uncaught:exception", () => false); // this is due to the fact that this is an invalid style for openlayers
when.select("modal:settings.maputnik:renderer", "ol");
then(get.inputValue("modal:settings.maputnik:renderer")).shouldEqual(
@@ -288,7 +288,7 @@ describe("modals", () => {
it("include API key when change renderer", () => {
test("include API key when change renderer", () => {
when.click("modal:settings.close-modal");
when.click("nav:open");
@@ -321,13 +321,13 @@ describe("modals", () => {
});
describe("add layer", () => {
test.describe("add layer", () => {
beforeEach(() => {
when.setStyle("layer");
when.modal.open();
});
it("shows duplicate id error", () => {
test("shows duplicate id error", () => {
when.setValue("add-layer.layer-id.input", "background");
when.click("add-layer");
then(get.elementByTestId("modal:add-layer")).shouldExist();
@@ -337,16 +337,16 @@ describe("modals", () => {
});
});
describe("sources", () => {
it("toggle");
test.describe("sources", () => {
test("toggle");
});
describe("global state", () => {
test.describe("global state", () => {
beforeEach(() => {
when.click("nav:global-state");
});
it("add variable", () => {
test("add variable", () => {
when.wait(100);
when.click("global-state-add-variable");
then(get.styleFromLocalStorage()).shouldDeepNestedInclude({
@@ -355,7 +355,7 @@ describe("modals", () => {
});
it("add multiple variables", () => {
test("add multiple variables", () => {
when.click("global-state-add-variable");
when.click("global-state-add-variable");
when.click("global-state-add-variable");
@@ -365,7 +365,7 @@ describe("modals", () => {
});
});
it("remove variable", () => {
test("remove variable", () => {
when.click("global-state-add-variable");
when.click("global-state-add-variable");
when.click("global-state-add-variable");
@@ -376,7 +376,7 @@ describe("modals", () => {
});
});
it("edit variable key", () => {
test("edit variable key", () => {
when.click("global-state-add-variable");
when.wait(100);
when.setValue("global-state-variable-key:0", "mykey");
@@ -387,7 +387,7 @@ describe("modals", () => {
});
});
it("edit variable value", () => {
test("edit variable value", () => {
when.click("global-state-add-variable");
when.wait(100);
when.setValue("global-state-variable-value:0", "myvalue");
@@ -399,12 +399,12 @@ describe("modals", () => {
});
});
describe("error panel", () => {
it("not visible when no errors", () => {
test.describe("error panel", () => {
test("not visible when no errors", () => {
then(get.element("maputnik-message-panel-error")).shouldNotExist();
});
it("visible on style error", () => {
test("visible on style error", () => {
when.modal.open();
when.modal.fillLayers({
type: "circle",
@@ -414,8 +414,8 @@ describe("modals", () => {
});
});
describe("Handle localStorage QuotaExceededError", () => {
it("handles quota exceeded error when opening style from URL", () => {
test.describe("Handle localStorage QuotaExceededError", () => {
test("handles quota exceeded error when opening style from URL", () => {
// Clear localStorage to start fresh
cy.clearLocalStorage();